From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6EB411FF139 for ; Tue, 10 Feb 2026 16:07:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1B4E96F49; Tue, 10 Feb 2026 16:08:04 +0100 (CET) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v6 proxmox-backup 15/18] client: Fail early if the same pipe is specified for multiple inputs Date: Tue, 10 Feb 2026 16:06:31 +0100 Message-ID: <20260210150642.469670-16-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260210150642.469670-1-r.obkircher@proxmox.com> References: <20260210150642.469670-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770735965890 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TCMRC3BTAW5RS37UHMY67X2XCQ3KPJRT X-Message-ID-Hash: TCMRC3BTAW5RS37UHMY67X2XCQ3KPJRT X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The pipe needs to be closed to finish the first archive, so the second one would always end up being empty. Duplicates are detected using the device id and inode number of the metadata. The inode number alone would not be sufficient for named pipes in a specific file system. Signed-off-by: Robert Obkircher --- proxmox-backup-client/src/main.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs index 1a51e88f..dcf7f84d 100644 --- a/proxmox-backup-client/src/main.rs +++ b/proxmox-backup-client/src/main.rs @@ -832,6 +832,7 @@ async fn create_backup( let mut upload_list = vec![]; let mut target_set = HashSet::new(); + let mut pipe_set = HashSet::new(); for backupspec in backupspec_list { let pbs_client::BackupSpecification { @@ -845,7 +846,7 @@ async fn create_backup( } target_set.insert(target.clone()); - use std::os::unix::fs::FileTypeExt; + use std::os::unix::fs::{FileTypeExt, MetadataExt}; let metadata = std::fs::metadata(&filename).map_err(|err| { if filename == "-" { @@ -870,6 +871,11 @@ async fn create_backup( } size } else if file_type.is_fifo() { + // dev is needed for named pipes + if !pipe_set.insert((metadata.dev(), metadata.ino())) { + // The second archive would be empty + bail!("got duplicate pipe '{filename}'"); + } 0 } else { if file_type.is_char_device() { @@ -917,6 +923,7 @@ async fn create_backup( } } } + drop(pipe_set); let backup_time = backup_time_opt.unwrap_or_else(epoch_i64); -- 2.47.3