From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4102C1FF136 for ; Mon, 09 Feb 2026 10:15:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E4CC37CC2; Mon, 9 Feb 2026 10:15:48 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 1/6] shared-memory: drop check for mmap file being located on tmpfs Date: Mon, 9 Feb 2026 10:15:17 +0100 Message-ID: <20260209091533.156902-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260209091533.156902-1-c.ebner@proxmox.com> References: <20260209091533.156902-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770628459831 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: M5OUMKBR4VCYYI6NFEBGCR4UZIV3K2C7 X-Message-ID-Hash: M5OUMKBR4VCYYI6NFEBGCR4UZIV3K2C7 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For some usecases, e.g. s3 client request counters, the mmapped file should outlive a reboot and must therefore be placed on persistent storage, not just a tmpfs. Drop the explicit check for the file being located on tmpfs. Signed-off-by: Christian Ebner --- proxmox-shared-memory/src/lib.rs | 7 ------- 1 file changed, 7 deletions(-) diff --git a/proxmox-shared-memory/src/lib.rs b/proxmox-shared-memory/src/lib.rs index b067d1b9..10c2c132 100644 --- a/proxmox-shared-memory/src/lib.rs +++ b/proxmox-shared-memory/src/lib.rs @@ -105,13 +105,6 @@ impl SharedMemory { .ok_or_else(|| format_err!("bad path {:?}", path))? .to_owned(); - if !dir_name.ends_with("shmemtest") { - let statfs = nix::sys::statfs::statfs(&dir_name)?; - if statfs.filesystem_type() != nix::sys::statfs::TMPFS_MAGIC { - bail!("path {:?} is not on tmpfs", dir_name); - } - } - let oflag = OFlag::O_RDWR | OFlag::O_CLOEXEC; // Try to open existing file -- 2.47.3