From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 45D5D1FF141 for ; Fri, 30 Jan 2026 17:46:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 697782CAB; Fri, 30 Jan 2026 17:46:50 +0100 (CET) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v5 proxmox-backup 08/16] api: verify fixed index writer size on close Date: Fri, 30 Jan 2026 17:45:32 +0100 Message-ID: <20260130164552.281581-9-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260130164552.281581-1-r.obkircher@proxmox.com> References: <20260130164552.281581-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769791537645 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3ONSQQHPYQCNOWVVZJCUV43M3VHTDDVS X-Message-ID-Hash: 3ONSQQHPYQCNOWVVZJCUV43M3VHTDDVS X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Compare it to the value submitted by the client to check that the resizing worked as expected. Signed-off-by: Robert Obkircher --- pbs-datastore/src/fixed_index.rs | 5 +++++ src/api2/backup/environment.rs | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/pbs-datastore/src/fixed_index.rs b/pbs-datastore/src/fixed_index.rs index 0f87bf15..c4fe899d 100644 --- a/pbs-datastore/src/fixed_index.rs +++ b/pbs-datastore/src/fixed_index.rs @@ -408,6 +408,11 @@ impl FixedIndexWriter { self.index_length } + /// The current total size of the referenced content. + pub fn size(&self) -> u64 { + self.size as u64 + } + fn unmap(&mut self) -> Result<(), Error> { let Some(index) = NonNull::new(self.index as *mut std::ffi::c_void) else { return Ok(()); diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs index 90a84ed2..dc4f9bf5 100644 --- a/src/api2/backup/environment.rs +++ b/src/api2/backup/environment.rs @@ -637,6 +637,14 @@ impl BackupEnvironment { } } + let writer_size = data.index.size(); + if size != writer_size { + bail!( + "fixed writer '{}' close failed - unexpected size ({size} != {writer_size})", + data.name, + ); + } + let expected_csum = data.index.close()?; data.closed = true; -- 2.47.3