From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EEA251FF13E for ; Fri, 23 Jan 2026 16:43:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03D7B117C0; Fri, 23 Jan 2026 16:43:47 +0100 (CET) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Date: Fri, 23 Jan 2026 16:37:18 +0100 Message-ID: <20260123154147.222215-6-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260123154147.222215-1-r.obkircher@proxmox.com> References: <20260123154147.222215-1-r.obkircher@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769182935499 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH v4 proxmox-backup 05/11] api: verify fixed index writer size on close X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Compare it to the value submitted by the client to check that the resizing worked as expected. Signed-off-by: Robert Obkircher --- pbs-datastore/src/fixed_index.rs | 5 +++++ src/api2/backup/environment.rs | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/pbs-datastore/src/fixed_index.rs b/pbs-datastore/src/fixed_index.rs index 4290da08..ecfe9b28 100644 --- a/pbs-datastore/src/fixed_index.rs +++ b/pbs-datastore/src/fixed_index.rs @@ -404,6 +404,11 @@ impl FixedIndexWriter { self.index_length } + /// The total size of the referenced content. This may be increased with [`grow_to_size`]. + pub fn size(&self) -> u64 { + self.size as u64 + } + fn unmap(&mut self) -> Result<(), Error> { let Some(index) = NonNull::new(self.index as *mut std::ffi::c_void) else { return Ok(()); diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs index 90a84ed2..dc4f9bf5 100644 --- a/src/api2/backup/environment.rs +++ b/src/api2/backup/environment.rs @@ -637,6 +637,14 @@ impl BackupEnvironment { } } + let writer_size = data.index.size(); + if size != writer_size { + bail!( + "fixed writer '{}' close failed - unexpected size ({size} != {writer_size})", + data.name, + ); + } + let expected_csum = data.index.close()?; data.closed = true; -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel