From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E53531FF179 for ; Thu, 22 Jan 2026 16:11:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2A8EC19D68; Thu, 22 Jan 2026 16:12:09 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 22 Jan 2026 16:11:20 +0100 Message-ID: <20260122151125.832787-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260122151125.832787-1-c.ebner@proxmox.com> References: <20260122151125.832787-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769094637904 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox 1/2] pbs-api-types: make operation non-optional for maintenance-mode check X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This checks the availability of the datastore constrained by the currently set maintenance-mode, based on the operation the caller would like to perform. In an effort to force the operation to be set when performing datastore operations, make this non optional for the maintenance mode checks. Signed-off-by: Christian Ebner --- pbs-api-types/src/maintenance.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs index 6b97ff10..5af34291 100644 --- a/pbs-api-types/src/maintenance.rs +++ b/pbs-api-types/src/maintenance.rs @@ -93,7 +93,7 @@ impl MaintenanceMode { || self.ty == MaintenanceType::Unmount } - pub fn check(&self, operation: Option) -> Result<(), Error> { + pub fn check(&self, operation: Operation) -> Result<(), Error> { if self.ty == MaintenanceType::Delete { bail!("datastore is being deleted"); } @@ -102,7 +102,7 @@ impl MaintenanceMode { .decode_utf8() .unwrap_or(Cow::Borrowed("")); - if let Some(Operation::Lookup) = operation { + if Operation::Lookup == operation { return Ok(()); } else if self.ty == MaintenanceType::Unmount { bail!("datastore is being unmounted"); @@ -111,7 +111,7 @@ impl MaintenanceMode { } else if self.ty == MaintenanceType::S3Refresh { bail!("S3 refresh maintenance mode: {}", message); } else if self.ty == MaintenanceType::ReadOnly { - if let Some(Operation::Write) = operation { + if Operation::Write == operation { bail!("read-only maintenance mode: {}", message); } } -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel