From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EB2031FF13F for ; Wed, 14 Jan 2026 13:32:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 473FA11870; Wed, 14 Jan 2026 13:32:28 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 14 Jan 2026 13:31:33 +0100 Message-ID: <20260114123139.505214-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768393868292 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox.com] Subject: [pbs-devel] [PATCH proxmox-backup v3 0/6] followups for garbage collection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This patch series contains some followup to the recently introduced changes to phase 2 of garbage collection on s3 backed datastores [0] and clenups for marker files during phase 3 [1], as well as some refactoring of the chunk filename extension parsing and bad chunk filename generation. The first patch introduces a dedicated struct for tracking objects to be deleted from the s3 object store during phase 2, bundling the length and age based deletion threshold logic to the list state. Subsequent patches rename and adapt the chunk store iterator to optimize for regular chunk filenames and clearly distinguish chunks by directory entry filename extension. Further, chunk extension parsing and bad chunk filename generation are moved to be associated functions of the newly introduced `ChunkExt` enum. Changes since version 2 (thanks @Fabian): - Consider delete list as above age threshold on time jumps to the past. - Align age and capacity threshold to be reached when value is equal (age needed to be greater in previous series, capacity was reached on equal). - Refactor chunk iterator and restrict filename extension checks - Lock chunk store before touching bad chunks, - Make cond_touch_path() private Changes since version 1: - Followup patches for refactoring extension parsing and bad chunk filename generation. [0] https://lore.proxmox.com/pbs-devel/2b637884-f6bd-434d-be00-fa4e9d9e2dcb@proxmox.com/T/ [1] https://lore.proxmox.com/pbs-devel/1764145262.ycdoq9dzrx.astroid@yuna.none/T/ proxmox-backup: Christian Ebner (6): GC: Move S3 delete list state and logic to a dedicated struct chunk store: rename and limit scope for chunk store iterator chunk store: return chunk extension and restrict chunk filename check datastore: move bad chunk touching logic to chunk store and lock it chunk store: move next bad chunk path generator into dedicated helper chunk store: move bad chunk filename generation into dedicated helper pbs-datastore/src/chunk_store.rs | 101 +++++++++++++++++--- pbs-datastore/src/datastore.rs | 159 ++++++++++++++++--------------- 2 files changed, 170 insertions(+), 90 deletions(-) Summary over all repositories: 2 files changed, 170 insertions(+), 90 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel