From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B1C261FF183 for ; Wed, 3 Dec 2025 16:33:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20BE0EDC2; Wed, 3 Dec 2025 16:33:34 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 3 Dec 2025 16:33:10 +0100 Message-ID: <20251203153310.598722-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764775965259 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs] Subject: [pbs-devel] [PATCH proxmox-backup] datastore: s3: use owner from local store cache instead of refetching X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Currently the owner file is fetched from the s3 backend for each backup group. This will however significantly increase the time needed for listing backup contents and cause additional requests which can be avoided. Simply use the local owner file instead. Signed-off-by: Christian Ebner --- This was reported in an enterprise support ticket. pbs-datastore/src/datastore.rs | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 36550ff63..9d36307ef 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -967,21 +967,6 @@ impl DataStore { backup_group: &pbs_api_types::BackupGroup, ) -> Result { let full_path = self.owner_path(ns, backup_group); - - if let DatastoreBackend::S3(s3_client) = self.backend()? { - let mut path = ns.path(); - path.push(backup_group.to_string()); - let object_key = crate::s3::object_key_from_path(&path, GROUP_OWNER_FILE_NAME) - .context("invalid owner file object key")?; - let response = proxmox_async::runtime::block_on(s3_client.get_object(object_key))? - .ok_or_else(|| format_err!("fetching owner failed"))?; - let content = proxmox_async::runtime::block_on(response.content.collect())?; - let owner = String::from_utf8(content.to_bytes().trim_ascii_end().to_vec())?; - return owner - .parse() - .map_err(|err| format_err!("parsing owner for {backup_group} failed: {err}")); - } - let owner = proxmox_sys::fs::file_read_firstline(full_path)?; owner .trim_end() // remove trailing newline -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel