From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 09B781FF16B for ; Fri, 21 Nov 2025 13:32:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 935EC20F28; Fri, 21 Nov 2025 13:32:50 +0100 (CET) From: Nicolas Frey To: pbs-devel@lists.proxmox.com Date: Fri, 21 Nov 2025 13:32:09 +0100 Message-ID: <20251121123209.198368-6-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251121123209.198368-1-n.frey@proxmox.com> References: <20251121123209.198368-1-n.frey@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox-backup 4/4] ui: verify: fetch default {read, verify} thread values from tuning options X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" making sure that the now default (e.g. emptyText) value matches the one found at the datastore-tuning level, we fetch the tuning data and bind it to the respective `emptyText` properties. Signed-off-by: Nicolas Frey --- www/window/VerifyAll.js | 38 +++++++++++++++++++++++++++++++++++-- www/window/VerifyJobEdit.js | 37 ++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 2 deletions(-) diff --git a/www/window/VerifyAll.js b/www/window/VerifyAll.js index 4239c215..e1670f10 100644 --- a/www/window/VerifyAll.js +++ b/www/window/VerifyAll.js @@ -11,6 +11,36 @@ Ext.define('PBS.window.VerifyAll', { url: `/admin/datastore/{datastore}/verify`, }, + viewModel: { + data: { + defaultReadThreads: null, + defaultVerifyThreads: null, + }, + }, + + initComponent: function () { + let me = this; + me.callParent(); + + if (me.datastore === undefined) { + return; + } + + Proxmox.Utils.API2Request({ + url: `/api2/extjs/config/datastore/${encodeURIComponent(me.datastore)}`, + method: 'GET', + success: ({ result }) => { + let raw = result?.data?.tuning || {}; + let tuning = PBS.Utils.parsePropertyString(raw); + + me.getViewModel().set({ + defaultReadThreads: tuning['verify-job-read-threads'] ?? 1, + defaultVerifyThreads: tuning['verify-job-verify-threads'] ?? 4, + }); + }, + }); + }, + submitText: gettext('Verify'), isCreate: true, showTaskViewer: true, @@ -84,7 +114,9 @@ Ext.define('PBS.window.VerifyAll', { xtype: 'proxmoxintegerfield', name: 'read-threads', fieldLabel: gettext('# of Read Threads'), - emptyText: '1', + bind: { + emptyText: '{defaultReadThreads}', + }, skipEmptyText: true, minValue: 1, maxValue: 32, @@ -93,7 +125,9 @@ Ext.define('PBS.window.VerifyAll', { xtype: 'proxmoxintegerfield', name: 'verify-threads', fieldLabel: gettext('# of Verify Threads'), - emptyText: '4', + bind: { + emptyText: '{defaultVerifyThreads}', + }, skipEmptyText: true, minValue: 1, maxValue: 32, diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js index 5650ed5c..8edc0865 100644 --- a/www/window/VerifyJobEdit.js +++ b/www/window/VerifyJobEdit.js @@ -32,8 +32,38 @@ Ext.define('PBS.window.VerifyJobEdit', { viewModel: { data: { ignoreVerified: true, + defaultReadThreads: null, + defaultVerifyThreads: null, }, }, + + loadThreadDefaults: function (datastore) { + Proxmox.Utils.API2Request({ + url: `/api2/extjs/config/datastore/${encodeURIComponent(datastore)}`, + method: 'GET', + success: ({ result }) => { + let raw = result?.data?.tuning || {}; + let tuning = PBS.Utils.parsePropertyString(raw); + + this.getViewModel().set({ + defaultReadThreads: tuning['verify-job-read-threads'] ?? 1, + defaultVerifyThreads: tuning['verify-job-verify-threads'] ?? 4, + }); + }, + }); + }, + + initComponent: function () { + let me = this; + me.callParent(); + + if (me.datastore === undefined) { + return; + } + + me.loadThreadDefaults(me.datastore); + }, + controller: { xclass: 'Ext.app.ViewController', control: { @@ -46,6 +76,7 @@ Ext.define('PBS.window.VerifyJobEdit', { let view = this.getView(); let nsSelector = view.down('pbsNamespaceSelector'); nsSelector.setDatastore(value); + view.loadThreadDefaults(value) }, }, @@ -164,6 +195,9 @@ Ext.define('PBS.window.VerifyJobEdit', { cbind: { deleteEmpty: '{!isCreate}', }, + bind: { + emptyText: '{defaultReadThreads}', + }, }, { xtype: 'proxmoxintegerfield', @@ -175,6 +209,9 @@ Ext.define('PBS.window.VerifyJobEdit', { cbind: { deleteEmpty: '{!isCreate}', }, + bind: { + emptyText: '{defaultVerifyThreads}', + }, }, ], advancedColumn2: [ -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel