From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BA60E1FF16B for ; Fri, 21 Nov 2025 13:32:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 551F020DF0; Fri, 21 Nov 2025 13:32:17 +0100 (CET) From: Nicolas Frey To: pbs-devel@lists.proxmox.com Date: Fri, 21 Nov 2025 13:32:07 +0100 Message-ID: <20251121123209.198368-4-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251121123209.198368-1-n.frey@proxmox.com> References: <20251121123209.198368-1-n.frey@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox-backup 2/4] verify: use tuning options' thread settings for {verify, read}-threads X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" uses the datastores' verify job thread settings as a secondary fallback: read_threads -> arg? -> datastore.read? -> 1 (default) verify_threads -> arg? -> datastore.verify? -> 4 (default) Signed-off-by: Nicolas Frey --- src/backup/verify.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/backup/verify.rs b/src/backup/verify.rs index 734c7b30..f52d7781 100644 --- a/src/backup/verify.rs +++ b/src/backup/verify.rs @@ -73,6 +73,16 @@ impl VerifyWorker { verify_threads: Option, ) -> Result { let backend = datastore.backend()?; + let thread_settings = datastore.thread_settings(); + + let read_threads = read_threads + .or(thread_settings.verify_job_read_threads) + .unwrap_or(1); + + let verify_threads = verify_threads + .or(thread_settings.verify_job_verify_threads) + .unwrap_or(4); + Ok(Self { worker, datastore, @@ -81,8 +91,8 @@ impl VerifyWorker { // start with 64 chunks since we assume there are few corrupt ones corrupt_chunks: Arc::new(Mutex::new(HashSet::with_capacity(64))), backend, - read_threads: read_threads.unwrap_or(1), - verify_threads: verify_threads.unwrap_or(4), + read_threads, + verify_threads, }) } -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel