From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B3C3E1FF179 for ; Wed, 12 Nov 2025 13:05:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1AC1C15C5; Wed, 12 Nov 2025 13:05:51 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Wed, 12 Nov 2025 13:05:10 +0100 Message-ID: <20251112120515.145480-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762949093399 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox{, -backup} v3 0/5] unmount datastores after sync job X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Adds the option to automatically unmount a datastore after a sync job finishes. The idea is that, in combination with run-on-mount, it is possible to have datastores sync to external drives without the need to open the web ui or terminal. This came up a handful of times in support and a recent thread on the forum. Basically, also non-tech people could be tasked with plugging and unplugging different drives regularly and mounting, sync and unmounting would be done automatically. Currently if any of the triggered jobs have the 'unmount-on-done' flag set the datastore will be unmounted right after the last of the triggered jobs finishes. This seemed pretty straight forward and should be good in most use-cases I came up with. v3, thanks @Fabian: - pull logic for unmounting out of endpoint so we can easily use the function directly instead of going through the API - add validation to sync job update endpoint, only allow unmount_on_done to be set if run_on_mount is set - unmounting now done by caller - improve commit message v2, thanks @Robert and @Shannon - include short docs section - fix typo - fix test - use `|=` (instead of `= ... || ...`) proxmox: Hannes Laimer (1): pbs-api-types: add 'unmount-on-done' field to sync job config pbs-api-types/src/jobs.rs | 9 +++++++++ 1 file changed, 9 insertions(+) proxmox-backup: Hannes Laimer (4): api: syncjob: correctly update/delete 'unmount-on-done' field api: datastore: auto-unmount after mount-triggered sync ui: add 'unmount-on-done' field to SyncJobEdit window docs: add section about `unmount-on-done` docs/managing-remotes.rst | 4 ++ src/api2/admin/datastore.rs | 96 ++++++++++++++++++++++--------------- src/api2/config/sync.rs | 12 +++++ www/window/SyncJobEdit.js | 26 ++++++++++ 4 files changed, 99 insertions(+), 39 deletions(-) Summary over all repositories: 5 files changed, 108 insertions(+), 39 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel