From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DAC4E1FF179 for ; Wed, 29 Oct 2025 17:01:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E985FD2B; Wed, 29 Oct 2025 17:01:40 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Wed, 29 Oct 2025 17:01:02 +0100 Message-ID: <20251029160103.241780-5-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251029160103.241780-1-h.laimer@proxmox.com> References: <20251029160103.241780-1-h.laimer@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761753654169 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2 3/4] ui: add 'unmount-on-done' field to SyncJobEdit window X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Tested-by: Robert Obkircher Signed-off-by: Hannes Laimer --- www/window/SyncJobEdit.js | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js index 14ffddcd..426c271f 100644 --- a/www/window/SyncJobEdit.js +++ b/www/window/SyncJobEdit.js @@ -122,6 +122,7 @@ Ext.define('PBS.window.SyncJobEdit', { } if (!me.isCreate) { PBS.Utils.delete_if_default(values, 'run-on-mount', false); + PBS.Utils.delete_if_default(values, 'unmount-on-done', false); PBS.Utils.delete_if_default(values, 'rate-in'); PBS.Utils.delete_if_default(values, 'rate-out'); PBS.Utils.delete_if_default(values, 'remote'); @@ -499,8 +500,30 @@ Ext.define('PBS.window.SyncJobEdit', { 'Run this job when a relevant removable datastore gets mounted.', ), }, + listeners: { + change: function (field, runOnMount) { + let me = this; + let view = me.up('pbsSyncJobEdit'); + let unmountOnDoneCb = view.down('field[name=unmount-on-done]'); + unmountOnDoneCb.setDisabled(!runOnMount); + }, + }, + uncheckedValue: false, + value: false, + }, + { + xtype: 'proxmoxcheckbox', + name: 'unmount-on-done', + fieldLabel: gettext('Unmount when done'), + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Unmount relevant removable datastore once sync job finishes.', + ), + }, uncheckedValue: false, value: false, + disabled: true, }, ], }, -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel