From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4848E1FF179 for ; Wed, 15 Oct 2025 18:40:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 801166B5; Wed, 15 Oct 2025 18:40:24 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 15 Oct 2025 18:40:03 +0200 Message-ID: <20251015164008.975591-6-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251015164008.975591-1-c.ebner@proxmox.com> References: <20251015164008.975591-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760546417497 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v3 3/8] GC: refactor atime gathering for local chunk markers with s3 backend X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Instead of setting the access time to the unix epoch and calculate the atime from that, directly set the value to 0 if the marker file is not present. This is in preparation for also checking the to be introduced upload markers to avoid GC races with upload/insert on s3 datastores. Signed-off-by: Christian Ebner --- pbs-datastore/src/datastore.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index b0386421f..45e079f1a 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -1649,14 +1649,16 @@ impl DataStore { // Check local markers (created or atime updated during phase1) and // keep or delete chunk based on that. let atime = match std::fs::metadata(&chunk_path) { - Ok(stat) => stat.accessed()?, + Ok(stat) => stat + .accessed()? + .duration_since(SystemTime::UNIX_EPOCH)? + .as_secs() as i64, Err(err) if err.kind() == std::io::ErrorKind::NotFound => { // File not found, delete by setting atime to unix epoch - SystemTime::UNIX_EPOCH + 0 } Err(err) => return Err(err.into()), }; - let atime = atime.duration_since(SystemTime::UNIX_EPOCH)?.as_secs() as i64; let bad = chunk_path .as_path() -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel