From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 24F8A1FF16F for ; Tue, 14 Oct 2025 13:54:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 79B9F172E; Tue, 14 Oct 2025 13:54:34 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Tue, 14 Oct 2025 13:53:53 +0200 Message-ID: <20251014115357.81105-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760442803313 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jobs.rs, datastore.rs, sync.rs] Subject: [pbs-devel] [PATCH proxmox{, -backup} 0/4] unmount datastores after sync job X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Adds the option to automatically unmount a datastore after a sync job finishes. The idea is that, in combination with run-on-mount, it is possible to have datastores sync to external drives without the need to open the web ui or terminal. This came up a handful of times in support and a recent thread on the forum. Basically, also non-tech people could be tasked with plugging and unplugging different drives regularly and mounting, sync and unmounting would be done automatically. Currently if any of the triggered jobs have the 'unmount-on-done' flag set the datastore will be unmounted right after the last of the triggered jobs finishes. This seemed pretty straight forward and should be good in most use-cases I came up with. Also, I did consider having 'unmount-on-done' also for normally(schedule/manual) started jobs, I guess there could be some situations where that might useful. But, as I mentioned on the commit itself, we'd probably have to go through the command socket since sync jobs run on the proxy. And I did not think it adds that much, also not sure if we'd even want that. proxmox: Hannes Laimer (1): pbs-api-types: add 'unmount-on-done' field to sync job config pbs-api-types/src/jobs.rs | 8 ++++++++ 1 file changed, 8 insertions(+) proxmox-backup: Hannes Laimer (3): api: syncjob: correctly update/delete 'unmount-on-done' field api: datastore: unmount datastore after sync if configured ui: add 'unmount-on-done' field to SyncJobEdit window src/api2/admin/datastore.rs | 21 +++++++++++++++++++-- src/api2/config/sync.rs | 8 ++++++++ www/window/SyncJobEdit.js | 23 +++++++++++++++++++++++ 3 files changed, 50 insertions(+), 2 deletions(-) Summary over all repositories: 4 files changed, 58 insertions(+), 2 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel