From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A93661FF183 for ; Wed, 24 Sep 2025 10:14:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 124591EAA8; Wed, 24 Sep 2025 10:15:29 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 24 Sep 2025 10:14:44 +0200 Message-ID: <20250924081444.129412-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758701681995 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] verify: silence incorrect backend error message for filesystem stores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" An incomplete check leads to the error messages of the form ``` failed to get s3 backend while trying to rename bad chunk: 4e4a... ``` when renaming a corrupt chunk on datastores with filesystem backend. Silence this message by correctly distinguishing the filesystem backend and backend error case. Fixes: https://forum.proxmox.com/threads/172579/ Signed-off-by: Christian Ebner --- src/backup/verify.rs | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/backup/verify.rs b/src/backup/verify.rs index b1452f267..f588f038c 100644 --- a/src/backup/verify.rs +++ b/src/backup/verify.rs @@ -90,7 +90,17 @@ impl VerifyWorker { } } - if let Ok(DatastoreBackend::S3(s3_client)) = datastore.backend() { + let backend = match datastore.backend() { + Ok(backend) => backend, + Err(err) => { + info!( + "failed to get backend while trying to rename bad chunk: {digest_str} - {err}" + ); + return; + } + }; + + if let DatastoreBackend::S3(s3_client) = backend { let suffix = format!(".{}.bad", counter); let target_key = match pbs_datastore::s3::object_key_from_digest_with_suffix(digest, &suffix) { @@ -122,8 +132,6 @@ impl VerifyWorker { // after all. return; } - } else { - info!("failed to get s3 backend while trying to rename bad chunk: {digest_str}"); } match std::fs::rename(&path, &new_path) { -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel