From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5F2C01FF187 for ; Mon, 25 Aug 2025 15:10:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3AE0F12E37; Mon, 25 Aug 2025 15:10:53 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 25 Aug 2025 15:10:06 +0200 Message-ID: <20250825131007.626777-7-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250825131007.626777-1-c.ebner@proxmox.com> References: <20250825131007.626777-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756127415386 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox v2 6/6] s3-client: use better fitting name for TCP idle time X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Although called tcp_keepalive in the HttpsConnector, the parameter sets the idle time before starting to send TCP keepalive requests [0]. Rename the constant to be better fitting, avoiding possible confusion with tcp keepalive interval. [0] https://git.proxmox.com/?p=proxmox.git;a=blob;f=proxmox-sys/src/linux/socket.rs;h=f1f108fb8c88c19cdd8850b17dc8191782d3d6ec;hb=HEAD#l13 Signed-off-by: Christian Ebner --- proxmox-s3-client/src/client.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs index e3845111..96a5878d 100644 --- a/proxmox-s3-client/src/client.rs +++ b/proxmox-s3-client/src/client.rs @@ -35,7 +35,7 @@ use crate::response_reader::{ pub const S3_HTTP_REQUEST_TIMEOUT: Duration = Duration::from_secs(30 * 60); const S3_HTTP_CONNECT_TIMEOUT: Duration = Duration::from_secs(10); -const S3_TCP_KEEPALIVE_TIME: u32 = 120; +const S3_TCP_KEEPIDLE_TIME: u32 = 120; const MAX_S3_UPLOAD_RETRY: usize = 3; // Assumed minimum upload rate of 1 KiB/s for dynamic put object request timeout calculation. const S3_MIN_ASSUMED_UPLOAD_RATE: u64 = 1024; @@ -154,7 +154,7 @@ impl S3Client { let https_connector = HttpsConnector::with_connector( http_connector, ssl_connector_builder.build(), - S3_TCP_KEEPALIVE_TIME, + S3_TCP_KEEPIDLE_TIME, ); let client = Client::builder(TokioExecutor::new()).build::<_, Body>(https_connector); -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel