From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 857EB1FF187 for ; Mon, 25 Aug 2025 15:10:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 06D9812BBA; Mon, 25 Aug 2025 15:10:52 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 25 Aug 2025 15:10:00 +0200 Message-ID: <20250825131007.626777-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756127414204 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox{, -backup} v2 0/7] fix #6665: never mark chunks as bad on s3 client fetch error X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This patch series fixes an issue with chunks being incorrectly marked as bad in case of s3 client fetch errors. In that case, only increase the error counter and log the error, but leave the chunk as is. To increase robusteness, implement a retry logic for all transient s3 client request errors with exponential backoff time. Further, unconditionally increase the get object request timeout from currently 1 minute to 30 minutes, to greatly reduce possible timeouts on low download bandwidth connections. Changes since version 1 (thanks @Wolfgang for offlist feedback): - Change timeout value to be independent of request retries - Adapt backoff time to be exponential, increasing initial value to 1 second - Do not increase tcp keepalive idle time, and rename const to avoid confusion proxmox: Christian Ebner (6): proxmox-http: add method to share full body as contiguous bytes s3-client: drop non-ambiguous mention of chunks in error message s3-client: fix unintended match statement being an expression s3-client: bump s3 request timeout from 1 minute to 30 minutes s3-client: add retry logic for transient client errors s3-client: use better fitting name for TCP idle time proxmox-http/src/body.rs | 8 ++++ proxmox-s3-client/src/client.rs | 74 +++++++++++++++++++++++---------- 2 files changed, 61 insertions(+), 21 deletions(-) proxmox-backup: Christian Ebner (1): fix #6665: never rename chunks on s3 client fetch errors src/backup/verify.rs | 35 +++++++++++++++++++++++------------ 1 file changed, 23 insertions(+), 12 deletions(-) Summary over all repositories: 3 files changed, 84 insertions(+), 33 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel