From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 50B141FF17C for ; Wed, 20 Aug 2025 11:57:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 64B0237677; Wed, 20 Aug 2025 11:58:52 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 20 Aug 2025 11:58:02 +0200 Message-ID: <20250820095807.172722-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755683855105 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, lib.rs, proxmox.com, client.rs, s3.rs] Subject: [pbs-devel] [PATCH proxmox{, -backup} 0/5] dynamically calculate request timeout for put object calls X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Currently, the s3 client sets a default timeout value of 60 seconds for each request send to the s3 api, independent of the request type. Put request uploading data can however take considerably more time, depending on the payload size and available upload bandwidth. This can lead to upload requests failing as reported in the community forum [0,1]. To partially fix this, calculate the request timeout for put object api calls based on the content size to be uploaded. Other issues due to network congestion might still arise, but might be circumvented via traffic shaping. To check the behaviour, the following `tc` filtering has been performed to limit the bandwidth to 10Mbit on the outgoing network interface ens18: ``` tc qdisc add dev ens18 root handle 1: htb tc class add dev ens18 parent 1: classid 1:1 htb rate 10Mbit tc filter add dev ens18 protocol ip parent 1: prio 1 u32 match ip dst 0/0 flowid 1:1 ``` The outgoing traffic has been monitored via `atop`. This is intended as stop gap until a more advance shared request and rate limiter is implemented for the s3 client. [0] https://forum.proxmox.com/threads/169620/ [1] https://forum.proxmox.com/threads/169432/ proxmox: Christian Ebner (3): s3-client: allow setting custom timeout when sending requests s3-client: dynamically calculate put request timeout based on payload s3-client: expose default timeout for s3 api requests proxmox-s3-client/examples/s3_client.rs | 3 +- proxmox-s3-client/src/client.rs | 51 +++++++++++++++++-------- proxmox-s3-client/src/lib.rs | 2 +- 3 files changed, 39 insertions(+), 17 deletions(-) proxmox-backup: Christian Ebner (2): s3: pass now optional default request timeout for s3 api calls api: format error to show full context for failed chunk uploads src/api2/admin/s3.rs | 9 +++++++-- src/api2/backup/upload_chunk.rs | 4 ++-- src/api2/config/datastore.rs | 3 ++- 3 files changed, 11 insertions(+), 5 deletions(-) Summary over all repositories: 6 files changed, 50 insertions(+), 22 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel