From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 039DF1FF15C for ; Fri, 8 Aug 2025 09:23:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8D165EA2F; Fri, 8 Aug 2025 09:24:46 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Fri, 8 Aug 2025 09:23:56 +0200 Message-ID: <20250808072356.90478-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754637829782 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] proxy: reduce log level for api_service() errors to log X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Since commit 9cf80dc6 ("proxy: avoid exiting connection acceptor loop in error case") errors occurring during REST server's api_service calls are logged as warning. The chosen warning log level is however a bit to eager, as errors are now logged to the systemd journal as well. This is not an issue per-se and can help debug connection issues. However, most health check tools such as e.g. HAProxy's backend health check periodically establish a connection and simply disconnect if successful, therefore spamming the journal with the following log lines: ``` ... Failed to get api service: Transport endpoint is not connected (os error 107) Failed to get api service: Transport endpoint is not connected (os error 107) ... ``` Therefore, lower the log level to debug which nevertheless allows to inspect possible errors when invoking the proxy with the respective log level, but does not spam the systemd journal by default. Signed-off-by: Christian Ebner --- src/bin/proxmox-backup-proxy.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs index cfd93f928..edd4871b8 100644 --- a/src/bin/proxmox-backup-proxy.rs +++ b/src/bin/proxmox-backup-proxy.rs @@ -313,7 +313,7 @@ async fn run() -> Result<(), Error> { api_service.serve(conn, Some(watcher)).await }); } - Err(err) => log::warn!("Failed to get api service: {err:?}"), + Err(err) => log::debug!("Failed to get api service: {err:?}"), } }, Err(err) => { log::warn!("Failed to accept secure connection: {err:?}"); } -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel