From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5782E1FF17C for ; Wed, 6 Aug 2025 12:08:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D24A7385EC; Wed, 6 Aug 2025 12:09:47 +0200 (CEST) From: Fiona Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 6 Aug 2025 12:07:03 +0200 Message-ID: <20250806100941.59272-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250806100941.59272-1-f.ebner@proxmox.com> References: <20250806100941.59272-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754474963508 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pbs3to4.rs] Subject: [pbs-devel] [PATCH proxmox-backup 2/2] pbs3to4: clippy: allow always true comparision against minimal value X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" MIN_PBS_PKGREL is a constant that is zero, so the check is currently superfluous, but that might not always be the case. Signed-off-by: Fiona Ebner --- src/bin/pbs3to4.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/bin/pbs3to4.rs b/src/bin/pbs3to4.rs index 46aa0a63..a60c77e2 100644 --- a/src/bin/pbs3to4.rs +++ b/src/bin/pbs3to4.rs @@ -98,6 +98,9 @@ impl Checker { let min_version = format!("{MIN_PBS_MAJOR}.{MIN_PBS_MINOR}.{MIN_PBS_PKGREL}"); + // MIN_PBS_PKGREL is currently zero, making the comparison further below + // superfluous, but this might not always be the case + #[allow(clippy::absurd_extreme_comparisons)] if maj > MIN_PBS_MAJOR { self.output .log_pass(format!("Already upgraded to Proxmox Backup Server {maj}"))?; -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel