From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F0F581FF16F for ; Tue, 5 Aug 2025 17:47:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C51B8198A9; Tue, 5 Aug 2025 17:48:55 +0200 (CEST) From: Shannon Sterz To: pbs-devel@lists.proxmox.com Date: Tue, 5 Aug 2025 17:48:20 +0200 Message-ID: <20250805154820.324167-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754408881205 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox] auth-api: log `authenticate` result not the return value of `start` X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" log the actual result of the `authenticate` call in order to make debugging authentication issues easier. previously we logged the result of the above `pam_sys::wrapped::start` call, which was typically `SUCCESS` leading to the very confusing error message: authentication error - SUCCESS (0) when in reality the authentication failed. note that pam uses the SUCCESS return code differently depending on the function that is called. `pam_start` uses it to communicate that a transaction was successfully started. `pam_authenticate` uses it to communicate that a user was successfully logged in. Signed-off-by: Shannon Sterz --- proxmox-auth-api/src/pam_authenticator.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-auth-api/src/pam_authenticator.rs b/proxmox-auth-api/src/pam_authenticator.rs index d34575be..ed8708da 100644 --- a/proxmox-auth-api/src/pam_authenticator.rs +++ b/proxmox-auth-api/src/pam_authenticator.rs @@ -64,7 +64,7 @@ impl crate::api::Authenticator for Pam { handle.result = pam_sys::wrapped::authenticate(handle.handle, pam_sys::types::PamFlag::NONE); if handle.result != PamReturnCode::SUCCESS { - bail!("authentication error - {err}"); + bail!("authentication error - {}", handle.result); } Ok(()) -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel