From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9BE161FF16F for ; Tue, 5 Aug 2025 12:50:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C5712CAB8; Tue, 5 Aug 2025 12:51:37 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 5 Aug 2025 12:51:20 +0200 Message-ID: <20250805105120.623089-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250805105120.623089-1-c.ebner@proxmox.com> References: <20250805105120.623089-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754391074925 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v4 2/2] ui: s3 endpoint: add provider specific quirk selector X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Add an advanced column with a provider specific quirk selector, which allows to set the s3 endpoint accordingly and use the provider specific implementation detail in the s3 client. Clear the value if it is set to the default one, being no quirks. For now only the one If-None-Match http header quirk is available, but this can be extended to a multi selection list if required. Signed-off-by: Christian Ebner --- changes since version 3: - use provider quirks directly instead of provider list www/window/S3ClientEdit.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js index f0a5efba8..5128f6a54 100644 --- a/www/window/S3ClientEdit.js +++ b/www/window/S3ClientEdit.js @@ -119,6 +119,23 @@ Ext.define('PBS.window.S3ClientEdit', { }, }, ], + + advancedColumn1: [ + { + xtype: 'proxmoxKVComboBox', + name: 'provider-quirks', + fieldLabel: gettext('Provider specific quirks'), + value: '__default__', + defaultValue: '__default__', + comboItems: [ + ['__default__', 'None (default)'], + ['skip-if-none-match-header', 'Skip If-None-Match header'], + ], + cbind: { + deleteEmpty: '{!isCreate}', + }, + }, + ], }, getValues: function () { -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel