From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A8A0B1FF165 for ; Thu, 31 Jul 2025 09:39:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C4A6234571; Thu, 31 Jul 2025 09:40:54 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 31 Jul 2025 09:39:45 +0200 Message-ID: <20250731073950.73526-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753947607001 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [RFC proxmox{, -backup} 0/5] switch local storage usage titles based on datastore backend X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This patches try to more clearly show to the user that the statistic shown in the datastore summary and overview only show the local cache usage. To achieve this, the first patches include the datastore backend type in both, responses for the `datastore-usage` as well as `status` api endpoints, in order to be able to adapt the shown information conditionally. Based on the backend, the title for the disk usage and rrd chart are adapted, the estimated full values are also not shown in case of local caches. This is intended more as a stop gap until a more sophisticated dashboard and statistics are implemented for S3 backends as tracked in [0]. Sending this as RFC as I am unsure if: - it is acceptable to include the backend type in these api responses, as they are intended for dynamic status changes? - there is a better/alternative way to get the backend type? - it might make sense to simply not return usage statistics for the cache (e.g. returning 0 values only) and keep this api endpoints free to be reused for the S3 dashboard? [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6563 proxmox: Christian Ebner (1): pbs-api-types: add backend type to datastore's status items pbs-api-types/src/datastore.rs | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) proxmox-backup: Christian Ebner (4): api: status: expose backend type in datastore status list item datastore: introduce helper to get store's backend type api: datastore: expose the datastore backend type in the status output ui: Set datastore usage related titles based on backend pbs-datastore/src/datastore.rs | 8 ++++++-- src/api2/admin/datastore.rs | 4 ++++ src/api2/status/mod.rs | 18 +++++++++++++++--- www/datastore/DataStoreListSummary.js | 10 ++++++++-- www/datastore/Summary.js | 12 ++++++++++++ 5 files changed, 45 insertions(+), 7 deletions(-) Summary over all repositories: 6 files changed, 64 insertions(+), 8 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel