From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 76CDD1FF17C for ; Wed, 23 Jul 2025 12:25:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A0FF2DCAD; Wed, 23 Jul 2025 12:26:18 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 23 Jul 2025 12:26:01 +0200 Message-ID: <20250723102601.495806-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250723102601.495806-1-c.ebner@proxmox.com> References: <20250723102601.495806-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753266365120 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox 3/3] s3 client: log error response body for invalid request status codes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" While the response body is already logged via `tracing` in case of unexpected status codes, this is not the case for invalid request response codes. Log the error response body for these cases as well, as they might contain further information to help debug issues. For example, an incorrectly composed delete_objects call might return the following error in the response body (reformatted from single line to multi line for better readability in the commit message): ``` MalformedXML The XML you provided was not well formed or did not validate against our published schema. ``` Signed-off-by: Christian Ebner --- proxmox-s3-client/src/response_reader.rs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/proxmox-s3-client/src/response_reader.rs b/proxmox-s3-client/src/response_reader.rs index 7aed4201..d8ca3b19 100644 --- a/proxmox-s3-client/src/response_reader.rs +++ b/proxmox-s3-client/src/response_reader.rs @@ -250,7 +250,10 @@ impl ResponseReader { StatusCode::OK => (), StatusCode::PRECONDITION_FAILED => return Ok(PutObjectResponse::PreconditionFailed), StatusCode::CONFLICT => return Ok(PutObjectResponse::NeedsRetry), - StatusCode::BAD_REQUEST => bail!("invalid request"), + StatusCode::BAD_REQUEST => { + Self::log_error_response_utf8(body); + bail!("invalid request"); + } status_code => { Self::log_error_response_utf8(body); bail!("unexpected status code {status_code}") @@ -283,7 +286,10 @@ impl ResponseReader { match parts.status { StatusCode::OK => (), - StatusCode::BAD_REQUEST => bail!("invalid request"), + StatusCode::BAD_REQUEST => { + Self::log_error_response_utf8(body); + bail!("invalid request"); + } status_code => { Self::log_error_response_utf8(body); bail!("unexpected status code {status_code}") -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel