From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 052871FF18A for ; Tue, 22 Jul 2025 18:35:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7086AE910; Tue, 22 Jul 2025 18:36:24 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 22 Jul 2025 18:36:00 +0200 Message-ID: <20250722163603.1520687-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753202170604 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [client.rs, datastore.rs, proxmox.com, s3.rs] Subject: [pbs-devel] [PATCH proxmox{, -backup} 0/3] followups for PBS s3 backend X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" These are followup patches to be applied on top of the patch series found here: https://lore.proxmox.com/pbs-devel/20250722101106.526438-1-c.ebner@proxmox.com/T/ Most notably, they fix a regression introduced in version v11, as discovered by Lukas. The api now did incorrectly return also the secret key for s3 endpoint configurations. Further, there is a patch which checks bucket access during datastore creation already in the api, before spawning the datastore create task. By this, if the bucket cannot be accessed, the user is notified right away and does not need to re-enter all the datastore configurations. proxmox: Christian Ebner (1): s3 client: split config api type into 3 config structs proxmox-s3-client/src/api_types.rs | 62 ++++++++++++++++++++++++------ proxmox-s3-client/src/client.rs | 3 +- 2 files changed, 52 insertions(+), 13 deletions(-) proxmox-backup: Christian Ebner (2): config: s3: adapt to new config struct layouts datastore: check s3 bucket access before create datastore task pbs-config/src/s3.rs | 7 ++-- pbs-datastore/src/datastore.rs | 11 +++-- src/api2/admin/s3.rs | 7 ++-- src/api2/config/datastore.rs | 76 ++++++++++++++++++++++++---------- src/api2/config/s3.rs | 65 ++++++++++++++++++++--------- 5 files changed, 114 insertions(+), 52 deletions(-) -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel