From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0A53C1FF1D4 for ; Tue, 22 Jul 2025 14:48:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6770E97C6; Tue, 22 Jul 2025 14:49:33 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 22 Jul 2025 14:48:37 +0200 Message-ID: <20250722124837.864242-7-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250722124837.864242-1-c.ebner@proxmox.com> References: <20250722124837.864242-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753188528983 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 6/6] ui: s3 client edit: allow for https scheme prefix in endpoint input X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Since S3 object store providers might show the endpoint via the https scheme prefix, allow this as valid user input for the ui, but strip it when sending the value. This is to reduce friction for the user when copy/pasting the value. Suggested-by: Thomas Lamprecht Signed-off-by: Christian Ebner --- www/window/S3ClientEdit.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js index 12d0b020d..6ebc8bfa8 100644 --- a/www/window/S3ClientEdit.js +++ b/www/window/S3ClientEdit.js @@ -130,6 +130,10 @@ Ext.define('PBS.window.S3ClientEdit', { } PBS.Utils.delete_if_default(values, 'path-style', false, me.isCreate); + let https_scheme_prefix = 'https://'; + if (values.endpoint.startsWith(https_scheme_prefix)) { + values.endpoint = values.endpoint.slice(https_scheme_prefix.length); + } if (values['access-key'] === '') { delete values['access-key']; } -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel