From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A3B621FF16F for ; Tue, 22 Jul 2025 14:48:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3BFED9781; Tue, 22 Jul 2025 14:49:31 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 22 Jul 2025 14:48:36 +0200 Message-ID: <20250722124837.864242-6-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250722124837.864242-1-c.ebner@proxmox.com> References: <20250722124837.864242-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753188528747 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 5/6] ui: default for s3 overwrite-in-use to be disabled X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" The flag only makes sense in combination with the reuse-existing datastore flag, which is unchecked by default. Therefore, opt for the overwrite-in-use flag to be disabled if unchecked and hidden if not an s3 datastore. Reported-by: Lukas Wagner Signed-off-by: Christian Ebner --- www/window/DataStoreEdit.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js index 24ef3563e..9552cb05e 100644 --- a/www/window/DataStoreEdit.js +++ b/www/window/DataStoreEdit.js @@ -78,6 +78,8 @@ Ext.define('PBS.DataStoreEdit', { let s3ClientSelector = inputPanel.down('[name=s3client]'); let overwriteInUseField = inputPanel.down('[name=overwrite-in-use]'); + let reuseDatastore = + inputPanel.down('[name=reuse-datastore]').getValue(); uuidEditField.setDisabled(!isRemovable); uuidEditField.allowBlank = !isRemovable; @@ -92,7 +94,7 @@ Ext.define('PBS.DataStoreEdit', { s3ClientSelector.setValue(''); overwriteInUseField.setHidden(!isS3); - overwriteInUseField.setDisabled(!isS3); + overwriteInUseField.setDisabled(!reuseDatastore); overwriteInUseField.setValue(false); if (isRemovable) { @@ -198,6 +200,8 @@ Ext.define('PBS.DataStoreEdit', { xtype: 'checkbox', name: 'overwrite-in-use', fieldLabel: gettext('Overwrite in-use marker'), + hidden: true, + disabled: true, }, ], -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel