From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A69DA1FF16F for ; Tue, 22 Jul 2025 14:47:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05E7F9676; Tue, 22 Jul 2025 14:49:01 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 22 Jul 2025 14:48:34 +0200 Message-ID: <20250722124837.864242-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250722124837.864242-1-c.ebner@proxmox.com> References: <20250722124837.864242-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753188528291 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 3/6] cli: use `endpoint` over `client` for s3 endpoint subcommands X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" In order to be consistent with the UI and thereby reduce possible confusion, where the naming was changed form `client` to `endpoint` as well. Signed-off-by: Christian Ebner --- src/bin/proxmox_backup_manager/s3.rs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/bin/proxmox_backup_manager/s3.rs b/src/bin/proxmox_backup_manager/s3.rs index 82bc9413a..867bc8e6b 100644 --- a/src/bin/proxmox_backup_manager/s3.rs +++ b/src/bin/proxmox_backup_manager/s3.rs @@ -10,7 +10,7 @@ use serde_json::Value; #[api( input: { properties: { - "s3-client-id": { + "s3-endpoint-id": { schema: S3_CLIENT_ID_SCHEMA, }, bucket: { @@ -25,12 +25,12 @@ use serde_json::Value; )] /// Perform basic sanity checks for given S3 client configuration async fn check( - s3_client_id: String, + s3_endpoint_id: String, bucket: String, store_prefix: String, rpcenv: &mut dyn RpcEnvironment, ) -> Result { - api2::admin::s3::check(s3_client_id, bucket, store_prefix, rpcenv).await?; + api2::admin::s3::check(s3_endpoint_id, bucket, store_prefix, rpcenv).await?; Ok(Value::Null) } @@ -69,7 +69,7 @@ fn list_s3_clients(param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result CommandLineInterface { - let client_cmd_def = CliCommandMap::new() + let endpoint_cmd_def = CliCommandMap::new() .insert("list", CliCommand::new(&API_METHOD_LIST_S3_CLIENTS)) .insert( "create", @@ -93,10 +93,10 @@ pub fn s3_commands() -> CommandLineInterface { .insert( "check", CliCommand::new(&API_METHOD_CHECK) - .arg_param(&["s3-client-id", "bucket"]) - .completion_cb("s3-client-id", pbs_config::s3::complete_s3_client_id), + .arg_param(&["s3-endpoint-id", "bucket"]) + .completion_cb("s3-endpoint-id", pbs_config::s3::complete_s3_client_id), ) - .insert("client", client_cmd_def); + .insert("endpoint", endpoint_cmd_def); cmd_def.into() } -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel