From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A0E201FF185 for ; Mon, 23 Jun 2025 16:13:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2A49014487; Mon, 23 Jun 2025 16:14:13 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Mon, 23 Jun 2025 16:13:06 +0200 Message-Id: <20250623141315.288681-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250623141315.288681-1-l.wagner@proxmox.com> References: <20250623141315.288681-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: change default notification mode to 'notification-system' X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" The former default was chose avoid breaking changes during a minor release, but with the upcoming major release we can change the default. The rationale for the new default is: - 'notification-system' was already used as a default for any datastore created by the GUI - consistency, since on PVE, the default is 'auto' (which does not exist on PBS, but is equivalent to 'notification-system' unless an email address has been added as well) - users are gently nudged to use the new notification stack The new default affects any datastore/tape backup job that has no explicit value set. On the PBS side some migration code will be added to d/postinst to migrate users who relied on the old default to the appropriate explicit setting. As mentioned above, the GUI already explicitly set the value to the new default for a long time. As a result, this mostly affects newly created datastores/tape jobs from the CLI/API. Signed-off-by: Lukas Wagner --- pbs-api-types/src/datastore.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index 5bd953ac..ecbeed8e 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -402,9 +402,9 @@ pub struct DataStoreConfig { pub enum NotificationMode { /// Send notifications via the system's sendmail command to the user /// configured in `notify-user` - #[default] LegacySendmail, /// Emit notification events to the notification system + #[default] NotificationSystem, } -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel