From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BE0EE1FF185 for ; Mon, 23 Jun 2025 16:13:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 31D79144E6; Mon, 23 Jun 2025 16:14:14 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Mon, 23 Jun 2025 16:13:14 +0200 Message-Id: <20250623141315.288681-10-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250623141315.288681-1-l.wagner@proxmox.com> References: <20250623141315.288681-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 8/9] ui: datastore options: drop notify and notify-user rows X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Even if the notification mode is set to 'notification-system', the datastore options grid still shows the keys for 'Notify' and 'Notify User', which have no effect in this mode: Notification: [Use global notification settings] Notify: [Prune: Default(always), etc...] Notify User: [root@pam] This is quite confusing. Unfortunately, it seems be quite hard to dynamically disable/hide rows in the grid panel used in this view. For that reason these rows are removed completely for now. The options are still visible when opening the edit window for the 'Notification' row. While this slightly worsens UX in some cases (information is hidden), it improves clarity by reducing ambiguity, which is also a vital part of good UX. Signed-off-by: Lukas Wagner --- www/datastore/OptionView.js | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js index 5a10a65d..913bdfc7 100644 --- a/www/datastore/OptionView.js +++ b/www/datastore/OptionView.js @@ -179,31 +179,6 @@ Ext.define('PBS.Datastore.Options', { xtype: 'pbsNotifyOptionEdit', }, }, - notify: { - required: true, - header: gettext('Notify'), - renderer: (value) => { - let notify = PBS.Utils.parsePropertyString(value); - let res = []; - for (const k of ['Verify', 'Sync', 'GC', 'Prune']) { - let fallback = k === 'Prune' ? 'Error' : 'Always'; - let v = Ext.String.capitalize(notify[k.toLowerCase()]) || fallback; - res.push(`${k}=${v}`); - } - return res.join(', '); - }, - editor: { - xtype: 'pbsNotifyOptionEdit', - }, - }, - 'notify-user': { - required: true, - defaultValue: 'root@pam', - header: gettext('Notify User'), - editor: { - xtype: 'pbsNotifyOptionEdit', - }, - }, 'verify-new': { required: true, header: gettext('Verify New Snapshots'), -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel