From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1BE311FF185 for ; Mon, 23 Jun 2025 16:13:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF97E14217; Mon, 23 Jun 2025 16:13:43 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Mon, 23 Jun 2025 16:13:05 +0200 Message-Id: <20250623141315.288681-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox{,-backup} 00/10] change of default notification-mode; UX improvements X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This is intended for the PBS 4.0 release (trixie based). This patch series changes the default notification mode for PBS to 'notification-system' from the former default of 'legacy-sendmail'. The rationale for the new default is: - 'notification-system' was already used as a default for any datastore created by the GUI - consistency, since on PVE, the default is 'auto' (which does not exist on PBS, but is equivalent to 'notification-system' unless an email address has been added as well) - users are gently nudged to use the new notification stack The new default affects any datastore/tape backup job that has no explicit value set. The proxmox-backup part of this series contains migration code which is invoked from d/postinst to migrate users who relied on the old default to the appropriate explicit setting. As mentioned above, the GUI already explicitly set the value to the new default for a long time. As a result, the changed default mostly affects newly created datastores/tape jobs which were created via third-party API users or the CLI. This patch series also contains various UX improvements to make the two notification modes much easier to understand. The approach is generally the same as in my series for PVE [1]. [1]: https://lore.proxmox.com/all/20250617084448.87536-1-l.wagner@proxmox.com/T/#t proxmox: Lukas Wagner (1): pbs-api-types: change default notification mode to 'notification-system' pbs-api-types/src/datastore.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) proxmox-backup: Lukas Wagner (9): cli: manager: move update-to-prune-jobs command to new migrate-config sub-command cli: manager: add 'migrate-config default-notification-mode' command d/postinst: migrate notification mode default on update ui: datastore options view: switch to new notification-mode default ui: tape backup job: move notification settings to a separate tab ui: one-shot tape backup: use same wording as tape-backup jobs ui: datastore options: notifications: use same jargon as tape-jobs and PVE ui: datastore options: drop notify and notify-user rows ui: datastore options: notification: use radio controls to select mode debian/postinst | 9 +- src/bin/proxmox-backup-manager.rs | 6 +- .../proxmox_backup_manager/migrate_config.rs | 171 ++++++++++++++++++ src/bin/proxmox_backup_manager/mod.rs | 1 + src/bin/proxmox_backup_manager/prune.rs | 87 +-------- www/datastore/OptionView.js | 33 +--- www/tape/window/TapeBackup.js | 10 +- www/tape/window/TapeBackupJob.js | 109 ++++++----- www/window/NotifyOptions.js | 43 +++-- 9 files changed, 292 insertions(+), 177 deletions(-) create mode 100644 src/bin/proxmox_backup_manager/migrate_config.rs Summary over all repositories: 10 files changed, 293 insertions(+), 178 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel