From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 7307E1FF183
for <inbox@lore.proxmox.com>; Wed, 21 May 2025 16:23:47 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C07F41A533;
Wed, 21 May 2025 16:23:48 +0200 (CEST)
From: Lukas Wagner <l.wagner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Wed, 21 May 2025 16:23:05 +0200
Message-Id: <20250521142309.264719-1-l.wagner@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.020 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH proxmox{, -widget-toolkit,
-backup} 0/4] notifications: add support for nested matchers
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
This series adds support for nested notification matchers. A new match rule is
added, 'eval-matcher', which allows to evaluate other matchers and use their
result in the current matcher.
Any matcher that shall be used as a nested matcher must have the (new) `nested`
flag set to true. These matchers are only evaluated if they are referenced
by another matcher. Any target configured for a nested matcher is ignored,
only the 'top-level'/'outermost' matcher decides which targets to notify.
This patch series includes:
- patches for proxmox-notify, which add the new config entries for matchers,
API methods and nested matcher evaluation
- patches for proxmox-backup, which contain documentation for the new
feature
- patches for proxmox-widget-toolkit, containing the GUI changes needed
for this feature.
Small config example:
matcher: top-level
target mail-to-root
mode any
eval-matcher a
eval-matcher b
matcher: a
nested true
mode all
match-field exact:datastore=store
match-field exact:type=gc
match-severity error
matcher: b
nested true
mode all
match-field exact:datastore=store
match-field exact:type=prune
match-severity error
The GUI remains functional if changes of proxmox-widget-toolkit are rolled out
before the proxmox-notify/proxmox-backup ones, so we should get away without
any sort of versioned break between widget-toolkit and proxmox-backup. Matchers
can be added/modified/deleted without problems, only if one tries to add a
nested-matcher rule or declare a matcher as a nested matcher an error is
displayed. Everything else should work.
Patches for PVE will follow once the core elements for this series have been
reviewed.
Note:
The patches for proxmox-notify are based on the `stable-bookworm` branch.
## Patch series revisions:
v1: you are here
proxmox:
Lukas Wagner (2):
notify: matcher: allow to evaluate other matchers via `eval-matcher`
notify: matcher: API: update methods for nested matcher support
proxmox-notify/src/api/matcher.rs | 229 +++++++++++++++++++++-
proxmox-notify/src/api/mod.rs | 4 +
proxmox-notify/src/lib.rs | 20 +-
proxmox-notify/src/matcher.rs | 313 ++++++++++++++++++++++++++++--
4 files changed, 532 insertions(+), 34 deletions(-)
proxmox-widget-toolkit:
Lukas Wagner (1):
notifications: matchers: add nested matcher support
src/data/model/NotificationConfig.js | 8 +-
src/panel/NotificationConfigView.js | 6 +
src/window/NotificationMatcherEdit.js | 220 +++++++++++++++++++++++++-
3 files changed, 232 insertions(+), 2 deletions(-)
proxmox-backup:
Lukas Wagner (1):
docs: notifications: add section about nested matchers
docs/notifications.rst | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
Summary over all repositories:
8 files changed, 787 insertions(+), 36 deletions(-)
--
Generated by git-murpp 0.8.1
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel