From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5769E1FF172 for <inbox@lore.proxmox.com>; Wed, 16 Apr 2025 14:57:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B708237248; Wed, 16 Apr 2025 14:57:30 +0200 (CEST) From: Maximiliano Sandoval <m.sandoval@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Wed, 16 Apr 2025 14:56:50 +0200 Message-Id: <20250416125651.334868-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.096 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH backup v3 1/2] http_client: store tickets in the user's config directory X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> The environment variable XDG_RUNTIME_DIR is only set if the user is logged into a seat. If, for example, the backup client was run with `sudo` then the ticket would not be a stored. By storing the ticket in the user's configuration directory, it can be reused later if the user logs out. Since the tickets are only valid for a limited time, it is not a problem if this file is not automatically cleaned. Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com> --- pbs-client/src/http_client.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pbs-client/src/http_client.rs b/pbs-client/src/http_client.rs index c95def07b..4f525f2ec 100644 --- a/pbs-client/src/http_client.rs +++ b/pbs-client/src/http_client.rs @@ -218,8 +218,8 @@ pub struct HttpClient { pub fn delete_ticket_info(prefix: &str, server: &str, username: &Userid) -> Result<(), Error> { let base = BaseDirectories::with_prefix(prefix)?; - // usually /run/user/<uid>/... - let path = base.place_runtime_file("tickets")?; + // usually ~/.config/<prefix>/tickets + let path = base.place_config_file("tickets")?; let mode = nix::sys::stat::Mode::from_bits_truncate(0o0600); @@ -307,8 +307,8 @@ fn store_ticket_info( ) -> Result<(), Error> { let base = BaseDirectories::with_prefix(prefix)?; - // usually /run/user/<uid>/... - let path = base.place_runtime_file("tickets")?; + // usually ~/.config/<prefix>/tickets + let path = base.place_config_file("tickets")?; let mode = nix::sys::stat::Mode::from_bits_truncate(0o0600); @@ -347,8 +347,8 @@ fn store_ticket_info( fn load_ticket_info(prefix: &str, server: &str, userid: &Userid) -> Option<(String, String)> { let base = BaseDirectories::with_prefix(prefix).ok()?; - // usually /run/user/<uid>/... - let path = base.place_runtime_file("tickets").ok()?; + // usually ~/.config/<prefix>/tickets + let path = base.place_config_file("tickets").ok()?; let data = file_get_json(path, None).ok()?; let now = proxmox_time::epoch_i64(); let ticket_lifetime = proxmox_auth_api::TICKET_LIFETIME - 60; -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel