From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CDFDE1FF15E for <inbox@lore.proxmox.com>; Tue, 8 Apr 2025 14:58:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DBDB11D44D; Tue, 8 Apr 2025 14:58:56 +0200 (CEST) From: Christian Ebner <c.ebner@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Tue, 8 Apr 2025 14:58:34 +0200 Message-Id: <20250408125839.196668-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [catalog.rs, push.rs, main.rs, mod.rs, sync.rs, environment.rs, diff.rs, download-speed.rs, proxmox.com, pull.rs, mount.rs] Subject: [pbs-devel] [PATCH v4 proxmox-backup 0/5] handle reader client disconnects X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> These patches attempt to improve the server side error handling for backukp reader client disconnects. During regular operation, the server currently cannot distinguish a disconnect because of error from a disconnect because of finished operation. This leaves behind a task in failed state, which is unexpected and might cause confusion [0]. To improve error handling, follow the approach taken for the backup writer tasks, letting the client signal it has successfully finished via an api call and catch the disconnect error for that case. The signaling of messages/warnings in case of client side aborts triggered by the user as suggested by Fabian has not been implemented, as that is currently not transparently handled by the client (only handled by BackupReader's Drop impl), therefore seemed out of scope for this patch series. changes since version 3: - rebased onto current master Reported in the community forum: [0] https://forum.proxmox.com/threads/158306/ Christian Ebner (5): client: reader: drop dead code backup debug: diff: refactor backup reader creation api: reader: handle reader client disconnects client: reader: add finish method to signal client state to server client: backup reader: call finish before dropping backup readers examples/download-speed.rs | 2 ++ pbs-client/src/backup_reader.rs | 10 +++--- proxmox-backup-client/src/catalog.rs | 2 ++ proxmox-backup-client/src/main.rs | 7 ++++ proxmox-backup-client/src/mount.rs | 3 ++ proxmox-file-restore/src/main.rs | 19 +++++++--- src/api2/reader/environment.rs | 20 ++++++++++- src/api2/reader/mod.rs | 24 ++++++++++--- src/bin/proxmox_backup_debug/diff.rs | 53 +++++++++++++--------------- src/server/pull.rs | 7 +++- src/server/push.rs | 2 +- src/server/sync.rs | 30 +++++++++------- 12 files changed, 123 insertions(+), 56 deletions(-) -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel