From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 3D8691FF189
for <inbox@lore.proxmox.com>; Fri, 21 Mar 2025 14:45:56 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E78101ED7E;
Fri, 21 Mar 2025 14:45:52 +0100 (CET)
From: Christoph Heiss <c.heiss@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Fri, 21 Mar 2025 14:45:30 +0100
Message-ID: <20250321134541.1106117-1-c.heiss@proxmox.com>
X-Mailer: git-send-email 2.48.1
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.027 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox-backup-api.rs, ldap.rs, proxmox.com, domain.rs, pbs.rs,
domains.rs, mod.rs, ad.rs, openid.rs, lib.rs, pam.rs]
Subject: [pbs-devel] [PATCH proxmox{,
-backup} v5 00/11] fix #5379: introduce default auth realm option
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
Fixes #5379 [0].
First, it adds an updatable `default` field to all existing editable
realms. Then it converts the PAM and PBS built-in realms to proper
realms, instead of being hard-coded in-between somewhere.
In turns this enables editing of these realms, allowing setting whether
these realms should be the default for login or not.
For patch #3 onwards, proxmox-backup needs patches #1 & #2 applied to
pbs-api-types and a bump thereof.
The proxmox-widget-toolkit parts have already been applied [1] and
proxmox-backup also pulls in the required version (introduced with pwt
4.3.1, proxmox-backup pulls in >= 4.3.3).
W.r.t. the inconsistency as discovered/discussed in [2], the (current)
behaviour is not changed in this series. Since both PVE and PBS use the
same realm login dialog from proxmox-widget-toolkit, I'd rather fix it
separately -- to avoid blocking this series on a completely separate
issue, which might still need some discussing.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=5379
[1] https://lore.proxmox.com/pbs-devel/d56c6e30-61d7-452b-afaa-5215d8538b4e@proxmox.com/#t
[2] https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010429.html
History
=======
v4: https://lore.proxmox.com/pbs-devel/20240823110737.831304-1-c.heiss@proxmox.com/
v3: https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010605.html
v2: https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010521.html
v1: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010250.html
Changes v4 -> v5:
* rebased on latest master, dropped already-applied pwt patches
Changes v3 -> v4:
* added proper PAM/PBS realm documentation
* reworked SimpleRealmInputPanel properties (thanks Gabriel & Hannes!)
Changes v2 -> v3:
* rebased on latest master
* fixed unsetting the `default` property by making it deletable
* unset previous default realm when creating a new realm with
`default` set
Changes v1 -> v2:
* rebased on latest master
* trivial fixes as suggested by Lukas
* add documentation to unset_default_realm()
Diffstat
========
proxmox:
Christoph Heiss (2):
fix #5379: api-types: add `default` field for all realm types
api-types: introduce proper types for PAM and PBS realms
pbs-api-types/src/ad.rs | 7 +++
pbs-api-types/src/ldap.rs | 7 +++
pbs-api-types/src/lib.rs | 120 +++++++++++++++++++++++++++++++++++-
pbs-api-types/src/openid.rs | 7 +++
4 files changed, 140 insertions(+), 1 deletion(-)
proxmox-backup:
Christoph Heiss (9):
fix #5379: api2: access: add `default` property for all realm types
fix #5379: api2: access: set default realm accordingly on individual
update
config: use new dedicated PAM and PBS realm types
api2: access: add update support for built-in PAM realm
api2: access: add update support for built-in PBS realm
www: AccessControl: make `useTypeInUrl` property per-realm
www: AccessControl: enable default realm checkbox for all realms
www: utils: make built-in PBS realm editable using new AuthSimplePanel
docs: user-management: document `pam` and `pbs` authentication realm
docs/user-management.rst | 30 ++++++-
pbs-config/src/domains.rs | 36 ++++++++-
src/api2/access/domain.rs | 13 ----
src/api2/config/access/ad.rs | 16 ++++
src/api2/config/access/ldap.rs | 16 ++++
src/api2/config/access/mod.rs | 4 +
src/api2/config/access/openid.rs | 16 ++++
src/api2/config/access/pam.rs | 130 +++++++++++++++++++++++++++++++
src/api2/config/access/pbs.rs | 130 +++++++++++++++++++++++++++++++
src/bin/proxmox-backup-api.rs | 1 +
src/config/mod.rs | 25 ++++++
www/OnlineHelpInfo.js | 8 ++
www/Utils.js | 5 +-
www/panel/AccessControl.js | 2 +-
14 files changed, 413 insertions(+), 19 deletions(-)
create mode 100644 src/api2/config/access/pam.rs
create mode 100644 src/api2/config/access/pbs.rs
--
2.45.1
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel