From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 01C1C1FF16B for <inbox@lore.proxmox.com>; Thu, 6 Mar 2025 13:44:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA4F55CAE; Thu, 6 Mar 2025 13:44:18 +0100 (CET) From: Shannon Sterz <s.sterz@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Thu, 6 Mar 2025 13:43:40 +0100 Message-Id: <20250306124349.288370-11-s.sterz@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250306124349.288370-1-s.sterz@proxmox.com> References: <20250306124349.288370-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.459 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.111.153, 185.199.110.153] Subject: [pbs-devel] [PATCH proxmox 10/19] acme/auth-api: add `Default` for types with un-parameterized `new()` X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> this fixes a clippy lint for types that have a `new()` function that has no parameters [1]. this should allow using these types with functions such as `unwrap_or_default()`. [1]: https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default Signed-off-by: Shannon Sterz <s.sterz@proxmox.com> --- proxmox-acme/src/types.rs | 6 ++++++ proxmox-auth-api/src/auth_key.rs | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/proxmox-acme/src/types.rs b/proxmox-acme/src/types.rs index e5a6b34d..0ec2deeb 100644 --- a/proxmox-acme/src/types.rs +++ b/proxmox-acme/src/types.rs @@ -38,6 +38,12 @@ pub enum AccountStatus { Revoked, } +impl Default for AccountStatus { + fn default() -> Self { + Self::new() + } +} + impl AccountStatus { /// Create a new instance with state New. #[inline] diff --git a/proxmox-auth-api/src/auth_key.rs b/proxmox-auth-api/src/auth_key.rs index 9873d935..500725d3 100644 --- a/proxmox-auth-api/src/auth_key.rs +++ b/proxmox-auth-api/src/auth_key.rs @@ -237,6 +237,12 @@ pub struct Keyring { public_keys: Vec<VerificationKey>, } +impl Default for Keyring { + fn default() -> Self { + Self::new() + } +} + impl Keyring { pub fn generate_new_rsa() -> Result<Self, Error> { PrivateKey::generate_rsa().map(Self::with_private_key) -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel