From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 54FFE1FF16B for <inbox@lore.proxmox.com>; Thu, 6 Mar 2025 13:44:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DB90F5DD0; Thu, 6 Mar 2025 13:44:44 +0100 (CET) From: Shannon Sterz <s.sterz@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Thu, 6 Mar 2025 13:43:30 +0100 Message-Id: <20250306124349.288370-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox 00/19] clippy, test and doc clean up X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> this series intends to clean up all clippy lints for all crates in the proxmox repo. it also makes sure all non-ignored test cases work again (some recent changes broke some test cases) and cleans up all warnings that were produced when running `cargo doc`. Shannon Sterz (19): io: clippy fix: replace `map()` followed by `any()` with just `any()` tree-wide: add parantheses to clarify precedence tree-wide: remove clone calls on types that are `Copy` tfa: don't use block in conditions tfa: remove needless `as_bytes` call access-control/tfa: use `?` instead of unnecessary match statements sys: add truncate option to `OpenOptions` in test case router: allow `from_str` on Confirmation that is not for `FromStr` auth-api/tfa: prefer `Display` over `ToString`/an inherent function acme/auth-api: add `Default` for types with un-parameterized `new()` shared-memory: specify generic types for transmute router: ignore clippy lint `missing_transmute_annotations` rest-server/router: ignore type complexity clippy lint apt: ignore clippy lint about using a slice reference instead of `&Vec` apt: ignore clippy lint about new having to return `Self` network-api: ignore clippy lint about upper case acronyms router: fix nested doc test cases to match inteded output api-macro: re-order ObjectSchema fields to be sorted tree-wide: fix intra doc links proxmox-access-control/src/acl.rs | 25 +++++++------------ proxmox-acme-api/src/challenge_schemas.rs | 1 + proxmox-acme/src/async_client.rs | 2 +- proxmox-acme/src/types.rs | 6 +++++ proxmox-api-macro/src/lib.rs | 13 +++++----- proxmox-apt/src/cache.rs | 1 + proxmox-apt/src/repositories/file.rs | 1 + proxmox-auth-api/src/auth_key.rs | 6 +++++ proxmox-auth-api/src/ticket.rs | 9 ++++--- proxmox-client/src/client.rs | 2 +- proxmox-compression/src/zip.rs | 2 +- proxmox-io/src/sparse_copy.rs | 3 +-- proxmox-log/src/file_logger.rs | 3 +-- proxmox-network-api/src/config/lexer.rs | 1 + .../examples/minimal-rest-server.rs | 1 + proxmox-rest-server/src/api_config.rs | 4 +-- proxmox-rest-server/src/worker_task.rs | 14 +++-------- proxmox-router/src/cli/mod.rs | 1 + proxmox-router/src/router.rs | 1 + proxmox-router/src/stream/parsing.rs | 1 + proxmox-router/tests/docs.rs | 3 +++ proxmox-rrd/src/cache.rs | 8 ++---- proxmox-rrd/src/cache/journal.rs | 18 +++---------- proxmox-rrd/src/cache/rrd_map.rs | 6 ++--- proxmox-schema/src/upid.rs | 2 +- proxmox-shared-cache/src/lib.rs | 18 +++---------- proxmox-shared-memory/src/lib.rs | 2 +- proxmox-sys/src/logrotate.rs | 2 +- proxmox-sys/src/systemd.rs | 2 +- proxmox-sys/tests/xattr.rs | 1 + proxmox-systemd/src/escape.rs | 2 +- proxmox-tfa/src/api/methods.rs | 23 +++++++++-------- proxmox-tfa/src/api/webauthn.rs | 10 +++++--- proxmox-tfa/src/totp.rs | 2 +- proxmox-uuid/src/lib.rs | 12 ++++----- 35 files changed, 99 insertions(+), 109 deletions(-) -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel