From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 2F3121FF16B
for <inbox@lore.proxmox.com>; Thu, 20 Feb 2025 11:24:28 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 52901E3F2;
Thu, 20 Feb 2025 11:24:23 +0100 (CET)
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Thu, 20 Feb 2025 11:24:01 +0100
Message-Id: <20250220102401.114634-1-c.ebner@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.031 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH proxmox] pbs api types: relax influx
organization and bucket length
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
Relax the length limit for organization and bucket name for InfluxDB
metric servers in Proxmox Backup Server.
Commit 57fa20406 ("pbs-api-types: add metrics api types") introduced
the api schema definition for InfluxDB metric servers, limiting the
name of the organization and the name of the bucket to a length of 3,
most likely as a result of reusing the same values as for the
corresponding config id schema restrictions.
This is however not enforced by the InfluxDB REST api [0, 1] and
stricter than what is defined in Proxmox VE [2].
Reported in the community forum [3].
[0] https://docs.influxdata.com/influxdb/v2/api/#operation/PostOrgs
[1] https://docs.influxdata.com/influxdb/v2/api/#operation/PostBuckets
[2] https://git.proxmox.com/?p=pve-manager.git;a=blob;f=PVE/Status/InfluxDB.pm;h=13a96711e766e2f1ea71424ed6d9d8ec8450504c;hb=HEAD#l24
[3] https://forum.proxmox.com/threads/162521/
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
pbs-api-types/src/metrics.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pbs-api-types/src/metrics.rs b/pbs-api-types/src/metrics.rs
index 014e28e4..ee901276 100644
--- a/pbs-api-types/src/metrics.rs
+++ b/pbs-api-types/src/metrics.rs
@@ -12,13 +12,13 @@ pub const METRIC_SERVER_ID_SCHEMA: Schema = StringSchema::new("Metrics Server ID
.schema();
pub const INFLUXDB_BUCKET_SCHEMA: Schema = StringSchema::new("InfluxDB Bucket.")
- .min_length(3)
+ .min_length(1)
.max_length(32)
.default("proxmox")
.schema();
pub const INFLUXDB_ORGANIZATION_SCHEMA: Schema = StringSchema::new("InfluxDB Organization.")
- .min_length(3)
+ .min_length(1)
.max_length(32)
.default("proxmox")
.schema();
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel