From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B4D451FF15E for <inbox@lore.proxmox.com>; Tue, 11 Feb 2025 17:26:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 87B114561; Tue, 11 Feb 2025 17:26:45 +0100 (CET) From: Filip Schauer <f.schauer@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Tue, 11 Feb 2025 17:26:39 +0100 Message-Id: <20250211162639.141541-3-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250211162639.141541-1-f.schauer@proxmox.com> References: <20250211162639.141541-1-f.schauer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> Reduce the number of MiB zeroed out at the start of the disk from 200 to 1. This should still be sufficient to remove any remaining signatures missed by `wipefs`, preventing potential interference with later use of the disk. Signed-off-by: Filip Schauer <f.schauer@proxmox.com> --- src/tools/disks/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs index ad9df0b5..deee60a6 100644 --- a/src/tools/disks/mod.rs +++ b/src/tools/disks/mod.rs @@ -1145,7 +1145,7 @@ pub fn inititialize_gpt_disk(disk: &Disk, uuid: Option<&str>) -> Result<(), Erro Ok(()) } -/// Wipes all labels, the first 200 MiB and the last 4096 bytes of a disk/partition. +/// Wipes all labels, the first 1 MiB and the last 4096 bytes of a disk/partition. /// If called with a partition, also sets the partition type to 0x83 'Linux filesystem'. pub fn wipe_blockdev(disk: &Disk) -> Result<(), Error> { let disk_path = match disk.device_path() { @@ -1198,7 +1198,7 @@ pub fn zero_disk_start_and_end(disk: &Disk) -> Result<(), Error> { .custom_flags(libc::O_CLOEXEC | libc::O_DSYNC) .open(disk_path) .with_context(|| "failed to open device {disk_path:?} for writing")?; - let write_size = disk_size.min(200 * 1024 * 1024); + let write_size = disk_size.min(1024 * 1024); let zeroes = proxmox_io::boxed::zeroed(write_size as usize); file.write_all_at(&zeroes, 0) .with_context(|| "failed to wipe start of device {disk_path:?}")?; -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel