From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/3] api: change integer schema parameters to i64
Date: Wed, 29 Jan 2025 11:42:50 +0100 [thread overview]
Message-ID: <20250129104250.934927-3-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250129104250.934927-1-s.hanreich@proxmox.com>
The type for the minimum / maximum / default values for integer
schemas has changed to i64 (from isize). Fix all call sites that are
converting to isize to convert to i64 instead.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
pbs-tape/src/bin/pmt.rs | 6 +++---
proxmox-backup-client/src/main.rs | 2 +-
pxar-bin/src/main.rs | 6 +++---
src/api2/backup/upload_chunk.rs | 15 ++++++---------
4 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/pbs-tape/src/bin/pmt.rs b/pbs-tape/src/bin/pmt.rs
index 9e39dbe1..685fa835 100644
--- a/pbs-tape/src/bin/pmt.rs
+++ b/pbs-tape/src/bin/pmt.rs
@@ -29,17 +29,17 @@ use pbs_tape::{
pub const FILE_MARK_COUNT_SCHEMA: Schema = IntegerSchema::new("File mark count.")
.minimum(1)
- .maximum(i32::MAX as isize)
+ .maximum(i32::MAX as i64)
.schema();
pub const FILE_MARK_POSITION_SCHEMA: Schema = IntegerSchema::new("File mark position (0 is BOT).")
.minimum(0)
- .maximum(i32::MAX as isize)
+ .maximum(i32::MAX as i64)
.schema();
pub const RECORD_COUNT_SCHEMA: Schema = IntegerSchema::new("Record count.")
.minimum(1)
- .maximum(i32::MAX as isize)
+ .maximum(i32::MAX as i64)
.schema();
pub const DRIVE_OPTION_SCHEMA: Schema =
diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
index 589a097b..3666a313 100644
--- a/proxmox-backup-client/src/main.rs
+++ b/proxmox-backup-client/src/main.rs
@@ -718,7 +718,7 @@ fn spawn_catalog_upload(
type: Integer,
description: "Max number of entries to hold in memory.",
optional: true,
- default: pbs_client::pxar::ENCODER_MAX_ENTRIES as isize,
+ default: pbs_client::pxar::ENCODER_MAX_ENTRIES as i64,
},
"dry-run": {
type: Boolean,
diff --git a/pxar-bin/src/main.rs b/pxar-bin/src/main.rs
index 7dff1e38..d0742f6b 100644
--- a/pxar-bin/src/main.rs
+++ b/pxar-bin/src/main.rs
@@ -330,9 +330,9 @@ fn extract_archive(
"entries-max": {
description: "Max number of entries loaded at once into memory",
optional: true,
- default: ENCODER_MAX_ENTRIES as isize,
+ default: ENCODER_MAX_ENTRIES as i64,
minimum: 0,
- maximum: isize::MAX,
+ maximum: i64::MAX,
},
"payload-output": {
description: "'ppxar' payload output data file to create split archive.",
@@ -354,7 +354,7 @@ async fn create_archive(
no_fifos: bool,
no_sockets: bool,
exclude: Option<Vec<String>>,
- entries_max: isize,
+ entries_max: i64,
payload_output: Option<String>,
) -> Result<(), Error> {
let patterns = {
diff --git a/src/api2/backup/upload_chunk.rs b/src/api2/backup/upload_chunk.rs
index 20259660..ca22efbd 100644
--- a/src/api2/backup/upload_chunk.rs
+++ b/src/api2/backup/upload_chunk.rs
@@ -133,10 +133,9 @@ pub const API_METHOD_UPLOAD_FIXED_CHUNK: ApiMethod = ApiMethod::new(
"encoded-size",
false,
&IntegerSchema::new("Encoded chunk size.")
- .minimum((std::mem::size_of::<DataBlobHeader>() as isize) + 1)
+ .minimum((std::mem::size_of::<DataBlobHeader>() as i64) + 1)
.maximum(
- 1024 * 1024 * 16
- + (std::mem::size_of::<EncryptedDataBlobHeader>() as isize)
+ 1024 * 1024 * 16 + (std::mem::size_of::<EncryptedDataBlobHeader>() as i64)
)
.schema()
),
@@ -202,10 +201,9 @@ pub const API_METHOD_UPLOAD_DYNAMIC_CHUNK: ApiMethod = ApiMethod::new(
"encoded-size",
false,
&IntegerSchema::new("Encoded chunk size.")
- .minimum((std::mem::size_of::<DataBlobHeader>() as isize) + 1)
+ .minimum((std::mem::size_of::<DataBlobHeader>() as i64) + 1)
.maximum(
- 1024 * 1024 * 16
- + (std::mem::size_of::<EncryptedDataBlobHeader>() as isize)
+ 1024 * 1024 * 16 + (std::mem::size_of::<EncryptedDataBlobHeader>() as i64)
)
.schema()
),
@@ -290,10 +288,9 @@ pub const API_METHOD_UPLOAD_BLOB: ApiMethod = ApiMethod::new(
"encoded-size",
false,
&IntegerSchema::new("Encoded blob size.")
- .minimum(std::mem::size_of::<DataBlobHeader>() as isize)
+ .minimum(std::mem::size_of::<DataBlobHeader>() as i64)
.maximum(
- 1024 * 1024 * 16
- + (std::mem::size_of::<EncryptedDataBlobHeader>() as isize)
+ 1024 * 1024 * 16 + (std::mem::size_of::<EncryptedDataBlobHeader>() as i64)
)
.schema()
)
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-01-29 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 10:42 [pbs-devel] [PATCH proxmox 1/3] schema: use i64 for minimum / maximum / default integer values Stefan Hanreich
2025-01-29 10:42 ` [pbs-devel] [PATCH proxmox 2/3] pbs-api-types: fix values for integer schemas Stefan Hanreich
2025-01-29 10:42 ` Stefan Hanreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129104250.934927-3-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox