public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] fix: docs: prune sim: show "keep" entries in backup list
@ 2025-01-22 13:38 Friedrich Weber
  2025-01-24  8:17 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Friedrich Weber @ 2025-01-22 13:38 UTC (permalink / raw)
  To: pbs-devel

Currently, the list of backups only shows removed backups and is
missing backups that are kept, though they are shown correctly in the
calendar view.

The reason is that a refactor (see Fixes tag) moved the definition of
a custom field renderer referencing `me` to a scope where `me` is not
defined. This causes the renderer to error out for "kept" backups,
which apparently causes the grid to skip the rows altogether (without
any messages in the console).

Fix this by replacing the broken `me` reference.

Fixes: bb044304 ("prune sim: move PruneList to more static declaration")
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
 docs/prune-simulator/prune-simulator_source.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/prune-simulator/prune-simulator_source.js b/docs/prune-simulator/prune-simulator_source.js
index 4bd31acd..0fb779e6 100644
--- a/docs/prune-simulator/prune-simulator_source.js
+++ b/docs/prune-simulator/prune-simulator_source.js
@@ -126,7 +126,8 @@ Ext.onReady(function() {
 			if (data.mark !== 'keep') {
 			    return `<div style="text-decoration: line-through;">${text}</div>`;
 			}
-			if (me.useColors) {
+			let pruneList = this.up('prunesimulatorPruneList');
+			if (pruneList.useColors) {
 			    let bgColor = COLORS[data.keepName];
 			    let textColor = TEXT_COLORS[data.keepName];
 			    return `<div style="background-color: ${bgColor};color: ${textColor};">${text}</div>`;
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] fix: docs: prune sim: show "keep" entries in backup list
  2025-01-22 13:38 [pbs-devel] [PATCH proxmox-backup] fix: docs: prune sim: show "keep" entries in backup list Friedrich Weber
@ 2025-01-24  8:17 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-01-24  8:17 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Friedrich Weber

Am 22.01.25 um 14:38 schrieb Friedrich Weber:
> Currently, the list of backups only shows removed backups and is
> missing backups that are kept, though they are shown correctly in the
> calendar view.
> 
> The reason is that a refactor (see Fixes tag) moved the definition of
> a custom field renderer referencing `me` to a scope where `me` is not
> defined. This causes the renderer to error out for "kept" backups,
> which apparently causes the grid to skip the rows altogether (without
> any messages in the console).
> 
> Fix this by replacing the broken `me` reference.
> 
> Fixes: bb044304 ("prune sim: move PruneList to more static declaration")
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
>  docs/prune-simulator/prune-simulator_source.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-24  8:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-22 13:38 [pbs-devel] [PATCH proxmox-backup] fix: docs: prune sim: show "keep" entries in backup list Friedrich Weber
2025-01-24  8:17 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal