From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DC0781FF173 for ; Mon, 13 Jan 2025 14:26:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3BFEE2F505; Mon, 13 Jan 2025 14:25:58 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Mon, 13 Jan 2025 14:25:52 +0100 Message-Id: <20250113132553.435319-4-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250113132553.435319-1-m.sandoval@proxmox.com> References: <20250113132553.435319-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.110.153, 185.199.109.153, 185.199.111.153, 185.199.108.153] Subject: [pbs-devel] [PATCH backup 4/5] sg_pt_changer: remove needless call to as_bytes() X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Fixes: warning: needless call to `as_bytes()` --> pbs-tape/src/sg_pt_changer.rs:913:45 | 913 | let rem = SCSI_VOLUME_TAG_LEN - voltag.as_bytes().len(); | ^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `voltag.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes = note: `#[warn(clippy::needless_as_bytes)]` on by default Signed-off-by: Maximiliano Sandoval --- pbs-tape/src/sg_pt_changer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pbs-tape/src/sg_pt_changer.rs b/pbs-tape/src/sg_pt_changer.rs index 940eed4a..7122fcdb 100644 --- a/pbs-tape/src/sg_pt_changer.rs +++ b/pbs-tape/src/sg_pt_changer.rs @@ -910,7 +910,7 @@ mod test { if let Some(voltag) = &desc.pvoltag { res.extend_from_slice(voltag.as_bytes()); - let rem = SCSI_VOLUME_TAG_LEN - voltag.as_bytes().len(); + let rem = SCSI_VOLUME_TAG_LEN - voltag.len(); if rem > 0 { res.resize(res.len() + rem, 0); } -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel