From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 284A61FF16B for ; Thu, 9 Jan 2025 15:07:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CC1E8FFE2; Thu, 9 Jan 2025 15:06:54 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 9 Jan 2025 15:06:18 +0100 Message-Id: <20250109140623.329770-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sync.rs, proxmox.com, catalog.rs, mod.rs, environment.rs, diff.rs, push.rs, main.rs, pull.rs, mount.rs, download-speed.rs] Subject: [pbs-devel] [PATCH v3 proxmox-backup 0/5] handle reader client disconnects X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" These patches attempt to improve the server side error handling for backukp reader client disconnects. During regular operation, the server currently cannot distinguish a disconnect because of error from a disconnect because of finished operation. This leaves behind a task in failed state, which is unexpected and might cause confusion [0]. To improve error handling, follow the approach taken for the backup writer tasks, letting the client signal it has successfully finished via an api call and catch the disconnect error for that case. The signaling of messages/warnings in case of client side aborts triggered by the user as suggested by Fabian has not been implemented, as that is currently not transparently handled by the client (only handled by BackupReader's Drop impl), therefore seemed out of scope for this patch series. Reported in the community forum: [0] https://forum.proxmox.com/threads/158306/ Version 2 of the patches: https://lore.proxmox.com/pbs-devel/20241204083149.58754-1-c.ebner@proxmox.com/T/ Christian Ebner (5): client: reader: drop dead code backup debug: diff: refactor backup reader creation api: reader: handle reader client disconnects client: reader: add finish method to signal client state to server client: backup reader: call finish before dropping backup readers examples/download-speed.rs | 2 ++ pbs-client/src/backup_reader.rs | 10 +++--- proxmox-backup-client/src/catalog.rs | 2 ++ proxmox-backup-client/src/main.rs | 7 ++++ proxmox-backup-client/src/mount.rs | 3 ++ proxmox-file-restore/src/main.rs | 19 +++++++--- src/api2/reader/environment.rs | 20 ++++++++++- src/api2/reader/mod.rs | 27 +++++++++++--- src/bin/proxmox_backup_debug/diff.rs | 53 +++++++++++++--------------- src/server/pull.rs | 7 +++- src/server/push.rs | 2 +- src/server/sync.rs | 30 +++++++++------- 12 files changed, 126 insertions(+), 56 deletions(-) -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel