From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id F03F41FF168 for ; Tue, 10 Dec 2024 16:54:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CB1E33B57; Tue, 10 Dec 2024 16:54:19 +0100 (CET) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Tue, 10 Dec 2024 16:53:44 +0100 Message-Id: <20241210155344.357910-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v3] restrict consent-banner text length X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Add a maxLength in of 63*1024 in the frontend. We allow a max body size of 64*1204 in the api and to allow some other properties to coexist, reserve 1024 characters. In the backend we set the limit to 128000 (128kB), which is the same as in pve. Signed-off-by: Gabriel Goller --- v3: - forgot to update the actual number in code v2, thanks @Thomas: - limit consent-text in the backend as well - set the limit according to the max body size src/config/node.rs | 5 +++++ www/config/NodeOptionView.js | 3 +++ 2 files changed, 8 insertions(+) diff --git a/src/config/node.rs b/src/config/node.rs index 2b29cb02afed..99c900cabf74 100644 --- a/src/config/node.rs +++ b/src/config/node.rs @@ -174,6 +174,11 @@ pub enum Translation { "description" : { optional: true, schema: MULTI_LINE_COMMENT_SCHEMA, + }, + "consent-text" : { + optional: true, + type: String, + max_length: 128000, } }, )] diff --git a/www/config/NodeOptionView.js b/www/config/NodeOptionView.js index c327356f7f24..042086a8ded5 100644 --- a/www/config/NodeOptionView.js +++ b/www/config/NodeOptionView.js @@ -59,6 +59,9 @@ Ext.define('PBS.NodeOptionView', { name: 'consent-text', text: gettext('Consent Text'), deleteEmpty: true, + fieldOpts: { + maxLength: 63 * 1024, + }, onlineHelp: 'consent_banner', }, ], -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel