From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E4CE61FF170 for ; Tue, 3 Dec 2024 12:28:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F3F141D26; Tue, 3 Dec 2024 12:28:54 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 3 Dec 2024 12:27:56 +0100 Message-Id: <20241203112756.63872-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241203112756.63872-1-c.ebner@proxmox.com> References: <20241203112756.63872-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 3/3] client: reader: signal server before client disconnect X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Signal the server that the client has successfully finished its operation and is about to close the connection. This allows the server side to react and clean up the connection gracefully, without returning and logging an error state, as that can cause confusion [0], as this is not an error but normal behaviour. Report in the community forum: [0] https://forum.proxmox.com/threads/158306/ Signed-off-by: Christian Ebner --- pbs-client/src/backup_reader.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pbs-client/src/backup_reader.rs b/pbs-client/src/backup_reader.rs index 88cba599b..63106c999 100644 --- a/pbs-client/src/backup_reader.rs +++ b/pbs-client/src/backup_reader.rs @@ -27,6 +27,8 @@ pub struct BackupReader { impl Drop for BackupReader { fn drop(&mut self) { + // Ignore errors + let _ = proxmox_async::runtime::block_on(self.post("finish", None)); self.abort.abort(); } } -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel