From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 887551FF170 for ; Tue, 3 Dec 2024 12:28:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 91ED31C66; Tue, 3 Dec 2024 12:28:23 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 3 Dec 2024 12:27:54 +0100 Message-Id: <20241203112756.63872-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/3] client: backup: remove unnecessary clone for backup writer X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This was introduced by commit fdea4e53 ("client: implement prepare reference method") to read a reference metadata archive for detection of unchanged, reusable files when using change detection mode set to `metadata`. Avoid unnecessary cloning of the atomic reference counted `BackupReader` instance, as it is used exclusively for this codepath. Signed-off-by: Christian Ebner --- proxmox-backup-client/src/main.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs index 9daa513f9..632a29170 100644 --- a/proxmox-backup-client/src/main.rs +++ b/proxmox-backup-client/src/main.rs @@ -1107,7 +1107,7 @@ async fn create_backup( &target, manifest.clone(), &client, - backup_reader.clone(), + backup_reader, crypt_config.clone(), crypto.mode, ) @@ -1310,7 +1310,7 @@ async fn prepare_reference( let most_used = metadata_ref_index.find_most_used_chunks(8); let file_info = manifest.lookup_file_info(&target)?; let chunk_reader = RemoteChunkReader::new( - backup_reader.clone(), + backup_reader, crypt_config.clone(), file_info.chunk_crypt_mode(), most_used, -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel