From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4A5F11FF170 for ; Tue, 3 Dec 2024 11:21:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 38CF5444; Tue, 3 Dec 2024 11:21:14 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Tue, 3 Dec 2024 11:20:35 +0100 Message-Id: <20241203102038.166031-7-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241203102038.166031-1-m.sandoval@proxmox.com> References: <20241203102038.166031-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 1 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.111.153, 185.199.108.153, 185.199.110.153, 185.199.109.153] Subject: [pbs-devel] [PATCH proxmox 07/10] remove unnecessary return statement X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Fixes the clippy lint: ``` warning: unneeded `return` statement --> proxmox-time/src/week_days.rs:31:14 | 31 | _ => return Err(parse_error(text, "weekday")), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 31 | _ => Err(parse_error(text, "weekday")), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Signed-off-by: Maximiliano Sandoval --- proxmox-apt/src/repositories/file/sources_parser.rs | 2 +- proxmox-time/src/week_days.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-apt/src/repositories/file/sources_parser.rs b/proxmox-apt/src/repositories/file/sources_parser.rs index 6d1eeb34..c85b8d2e 100644 --- a/proxmox-apt/src/repositories/file/sources_parser.rs +++ b/proxmox-apt/src/repositories/file/sources_parser.rs @@ -43,7 +43,7 @@ impl APTSourcesFileParser { if key.starts_with('-') { return false; }; - return key.chars().all(|c| matches!(c, '!'..='9' | ';'..='~')); + key.chars().all(|c| matches!(c, '!'..='9' | ';'..='~')) } /// Try parsing a repository in stanza format from `lines`. diff --git a/proxmox-time/src/week_days.rs b/proxmox-time/src/week_days.rs index da446c5b..c409d292 100644 --- a/proxmox-time/src/week_days.rs +++ b/proxmox-time/src/week_days.rs @@ -28,7 +28,7 @@ fn parse_weekday(i: &str) -> IResult<&str, WeekDays> { "friday" | "fri" => Ok((i, WeekDays::FRIDAY)), "saturday" | "sat" => Ok((i, WeekDays::SATURDAY)), "sunday" | "sun" => Ok((i, WeekDays::SUNDAY)), - _ => return Err(parse_error(text, "weekday")), + _ => Err(parse_error(text, "weekday")), } } -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel