From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 989D81FF15F for ; Mon, 2 Dec 2024 14:10:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 27CAC17ECC; Mon, 2 Dec 2024 14:10:13 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Mon, 2 Dec 2024 14:10:06 +0100 Message-Id: <20241202131008.410529-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 1 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.110.153, 185.199.108.153, 185.199.109.153, 185.199.111.153] Subject: [pbs-devel] [PATCH backup 1/3] docs: remove empty lines in doc strings X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Fixes the clippy lint: ``` warning: empty line after doc comment --> src/tape/pool_writer/mod.rs:441:5 | 441 | / /// updated. 442 | | | |_ ... 448 | / pub fn append_snapshot_archive( 449 | | &mut self, 450 | | snapshot_reader: &SnapshotReader, 451 | | ) -> Result<(bool, usize), Error> { | |_____________________________________- the comment documents this method | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 442 | /// | ``` Signed-off-by: Maximiliano Sandoval --- pbs-client/src/catalog_shell.rs | 1 - pbs-datastore/src/chunker.rs | 1 - src/tape/pool_writer/mod.rs | 4 ++-- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/pbs-client/src/catalog_shell.rs b/pbs-client/src/catalog_shell.rs index 550daf56b..20f323a22 100644 --- a/pbs-client/src/catalog_shell.rs +++ b/pbs-client/src/catalog_shell.rs @@ -303,7 +303,6 @@ async fn restore_command(target: String, pattern: Option) -> Result<(), /// The `Path` type's component iterator does not tell us anything about trailing slashes or /// trailing `Component::CurDir` entries. Since we only support regular paths we'll roll our own /// here: - pub struct Shell { /// Readline instance handling input and callbacks rl: rustyline::Editor, diff --git a/pbs-datastore/src/chunker.rs b/pbs-datastore/src/chunker.rs index ecdbca296..bf1e8d8df 100644 --- a/pbs-datastore/src/chunker.rs +++ b/pbs-datastore/src/chunker.rs @@ -30,7 +30,6 @@ pub trait Chunker { /// information please take a look at the [Rolling /// Hash](https://en.wikipedia.org/wiki/Rolling_hash) article from /// Wikipedia. - pub struct ChunkerImpl { h: u32, window_size: usize, diff --git a/src/tape/pool_writer/mod.rs b/src/tape/pool_writer/mod.rs index 9731e1cc8..3114ec061 100644 --- a/src/tape/pool_writer/mod.rs +++ b/src/tape/pool_writer/mod.rs @@ -332,7 +332,7 @@ impl PoolWriter { /// Move to EOM (if not already there), then write the current /// catalog to the tape. On success, this return 'Ok(true)'. - + /// /// Please note that this may fail when there is not enough space /// on the media (return value 'Ok(false, _)'). In that case, the /// archive is marked incomplete. The caller should mark the media @@ -439,7 +439,7 @@ impl PoolWriter { /// archive writing specified files (as .pxar) into it. On /// success, this return 'Ok(true)' and the media catalog gets /// updated. - + /// /// Please note that this may fail when there is not enough space /// on the media (return value 'Ok(false, _)'). In that case, the /// archive is marked incomplete, and we do not use it. The caller -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel