From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0F22A1FF15F for ; Mon, 2 Dec 2024 10:58:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 74DEE12DF7; Mon, 2 Dec 2024 10:58:17 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Mon, 2 Dec 2024 10:58:02 +0100 Message-Id: <20241202095808.128299-7-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241202095808.128299-1-m.sandoval@proxmox.com> References: <20241202095808.128299-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.355 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.110.153, 185.199.108.153, 185.199.109.153, 185.199.111.153] Subject: [pbs-devel] [PATCH backup 07/13] remove needless type conversion X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" The mount types were probably here for compatibility with older proxmox-sys. Fixes the useless_conversion clippy lints: ``` warning: useless conversion to the same type: `std::os::fd::OwnedFd` --> proxmox-backup-client/src/mount.rs:172:23 | 172 | let pr: OwnedFd = pr.into(); // until next sys bump | ^^^^^^^^^ help: consider removing `.into()`: `pr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default warning: useless conversion to the same type: `std::os::fd::OwnedFd` --> proxmox-backup-client/src/mount.rs:173:23 | 173 | let pw: OwnedFd = pw.into(); | ^^^^^^^^^ help: consider removing `.into()`: `pw` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion warning: useless conversion to the same type: `pbs_api_types::BackupArchiveName` --> proxmox-file-restore/src/main.rs:484:18 | 484 | &archive_name.try_into()?, | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider removing `.try_into()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default ``` Signed-off-by: Maximiliano Sandoval --- proxmox-backup-client/src/mount.rs | 2 -- proxmox-file-restore/src/main.rs | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/proxmox-backup-client/src/mount.rs b/proxmox-backup-client/src/mount.rs index 0048a8ad4..4929f5e5d 100644 --- a/proxmox-backup-client/src/mount.rs +++ b/proxmox-backup-client/src/mount.rs @@ -169,8 +169,6 @@ fn mount( // Process should be daemonized. // Make sure to fork before the async runtime is instantiated to avoid troubles. let (pr, pw) = proxmox_sys::pipe()?; - let pr: OwnedFd = pr.into(); // until next sys bump - let pw: OwnedFd = pw.into(); match unsafe { fork() } { Ok(ForkResult::Parent { .. }) => { drop(pw); diff --git a/proxmox-file-restore/src/main.rs b/proxmox-file-restore/src/main.rs index bbfc6eb4e..59ccbe524 100644 --- a/proxmox-file-restore/src/main.rs +++ b/proxmox-file-restore/src/main.rs @@ -479,7 +479,7 @@ async fn extract( let (archive_name, payload_archive_name) = pbs_client::tools::get_pxar_archive_names(&archive_name, &manifest)?; let (reader, archive_size) = get_remote_pxar_reader( - &archive_name.try_into()?, + &archive_name, client.clone(), &manifest, crypt_config.clone(), -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel