From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C28841FF15F for ; Mon, 2 Dec 2024 10:58:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AAF4712F0F; Mon, 2 Dec 2024 10:58:17 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Mon, 2 Dec 2024 10:58:07 +0100 Message-Id: <20241202095808.128299-12-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241202095808.128299-1-m.sandoval@proxmox.com> References: <20241202095808.128299-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.351 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.108.153, 185.199.110.153, 185.199.111.153, 185.199.109.153] Subject: [pbs-devel] [PATCH backup 12/13] datastore: simplify let-else block with ? operator X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Fixes the question_mark clippy lint: ``` warning: this `let...else` may be rewritten with the `?` operator --> pbs-datastore/src/datastore.rs:101:5 | 101 | / let Some(ref device_uuid) = config.backing_device else { 102 | | return None; 103 | | }; | |______^ help: replace it with: `let ref device_uuid = config.backing_device?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `#[warn(clippy::question_mark)]` on by default ``` Signed-off-by: Maximiliano Sandoval --- pbs-datastore/src/datastore.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 24d9eab2e..cf55befaa 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -98,9 +98,7 @@ fn is_datastore_mounted_at(store_mount_point: String, device_uuid: &str) -> bool } pub fn get_datastore_mount_status(config: &DataStoreConfig) -> Option { - let Some(ref device_uuid) = config.backing_device else { - return None; - }; + let device_uuid = config.backing_device.as_ref()?; Some(is_datastore_mounted_at(config.absolute_path(), device_uuid)) } -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel