From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A250A1FF171 for ; Fri, 29 Nov 2024 16:39:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E4D341C646; Fri, 29 Nov 2024 16:39:41 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 29 Nov 2024 16:39:08 +0100 Message-Id: <20241129153908.4141576-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] add missing O_CLOEXEC flags to `openat` calls X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" since we don't want to have lingering file descriptors on reload, which does a fork/exec. Signed-off-by: Dominik Csapak --- pbs-client/src/pxar/dir_stack.rs | 2 +- pbs-datastore/src/backup_info.rs | 2 +- pbs-datastore/src/snapshot_reader.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pbs-client/src/pxar/dir_stack.rs b/pbs-client/src/pxar/dir_stack.rs index 616d7545b..6fe55f170 100644 --- a/pbs-client/src/pxar/dir_stack.rs +++ b/pbs-client/src/pxar/dir_stack.rs @@ -57,7 +57,7 @@ impl PxarDir { let dir = Dir::openat( parent, self.file_name.as_os_str(), - OFlag::O_DIRECTORY, + OFlag::O_DIRECTORY | OFlag::O_CLOEXEC, Mode::empty(), )?; diff --git a/pbs-datastore/src/backup_info.rs b/pbs-datastore/src/backup_info.rs index be262773b..1ca279aca 100644 --- a/pbs-datastore/src/backup_info.rs +++ b/pbs-datastore/src/backup_info.rs @@ -143,7 +143,7 @@ impl BackupGroup { match openat( l2_fd, &manifest_path, - OFlag::O_RDONLY, + OFlag::O_RDONLY | OFlag::O_CLOEXEC, nix::sys::stat::Mode::empty(), ) { Ok(rawfd) => { diff --git a/pbs-datastore/src/snapshot_reader.rs b/pbs-datastore/src/snapshot_reader.rs index 95e59a421..dea51cbef 100644 --- a/pbs-datastore/src/snapshot_reader.rs +++ b/pbs-datastore/src/snapshot_reader.rs @@ -102,7 +102,7 @@ impl SnapshotReader { let raw_fd = nix::fcntl::openat( self.locked_dir.as_raw_fd(), Path::new(filename), - nix::fcntl::OFlag::O_RDONLY, + nix::fcntl::OFlag::O_RDONLY | nix::fcntl::OFlag::O_CLOEXEC, nix::sys::stat::Mode::empty(), )?; let file = unsafe { File::from_raw_fd(raw_fd) }; -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel